fix(deps): adopt knative-operator 1.23.1 (chart URL pin) - #22
Conversation
Renovate set $operatorChartVersion to v1.23.1, but the Helm url already prefixes knative-v%s. Chart.yaml version is 1.23.1. Keep the 1.21 values keys (knative_operator.{knative_operator,operator_webhook}).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change updates the Knative operator Helm chart from version ChangesKnative operator release
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The update is mergeable with normal validation; no concrete current-head risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Published Crossplane PackageThe following Crossplane package was published as part of this PR: Package: ghcr.io/hops-ops/knative-stack:pr-22-e37f663aeceab93c8240e290dc62b4bc5750244d |
Summary
Adopts knative-operator 1.21.0 → 1.23.1 with the version pin our renderer actually uses.
Renovate #18 set
$operatorChartVersiontov1.23.1. This template already prefixesknative-v%s/knative-operator-v%s.tgz, so that resolved toknative-vv1.23.1(404). Upstream Chart.yaml version is1.23.1; the real asset is https://github.com/knative/operator/releases/download/knative-v1.23.1/knative-operator-v1.23.1.tgz.Usage review
We only set
knative_operator.knative_operator/knative_operator.operator_webhookresources, plus optional nodePool affinity/tolerations. Those keys still exist in the 1.23.1 values.yaml. Tests assert those keys, not the chart version string. No values-schema rewrite.Test plan
vURL)knative-operator-v1.23.1.tgzSupersedes the version pin in #18 (keep that PR closed or let it rebase after this lands).
Summary by CodeRabbit