Skip to content

fix(deps): adopt knative-operator 1.23.1 (chart URL pin) - #22

Merged
patrickleet merged 2 commits into
mainfrom
adopt/knative-operator-1.23.1
Sep 12, 2026
Merged

patrickleet merged 2 commits into
mainfrom
adopt/knative-operator-1.23.1

Conversation

@patrickleet

@patrickleet patrickleet commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Adopts knative-operator 1.21.0 → 1.23.1 with the version pin our renderer actually uses.

Renovate #18 set $operatorChartVersion to v1.23.1. This template already prefixes knative-v%s / knative-operator-v%s.tgz, so that resolved to knative-vv1.23.1 (404). Upstream Chart.yaml version is 1.23.1; the real asset is https://github.com/knative/operator/releases/download/knative-v1.23.1/knative-operator-v1.23.1.tgz.

Usage review

We only set knative_operator.knative_operator / knative_operator.operator_webhook resources, plus optional nodePool affinity/tolerations. Those keys still exist in the 1.23.1 values.yaml. Tests assert those keys, not the chart version string. No values-schema rewrite.

Test plan

Supersedes the version pin in #18 (keep that PR closed or let it rebase after this lands).

Summary by CodeRabbit

  • Chores
    • Updated the Knative Operator release to chart version 1.23.1.

renovate Bot and others added 2 commits September 11, 2026 12:08
Renovate set $operatorChartVersion to v1.23.1, but the Helm url already prefixes knative-v%s. Chart.yaml version is 1.23.1. Keep the 1.21 values keys (knative_operator.{knative_operator,operator_webhook}).
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f9fe3eeb-c425-4890-9f97-114e6cba9584

📥 Commits

Reviewing files that changed from the base of the PR and between e3a557c and 67a4fb3.

📒 Files selected for processing (1)
  • functions/render/210-knative-operator.yaml.gotmpl

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates the Knative operator Helm chart from version 1.21.0 to 1.23.1 in the rendered release manifest template.

Changes

Knative operator release

Layer / File(s) Summary
Update operator chart version
functions/render/210-knative-operator.yaml.gotmpl
The template now references Knative operator chart version 1.23.1 and its corresponding download URL.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 67a4f

The update is mergeable with normal validation; no concrete current-head risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the dependency update to knative-operator 1.23.1 and the chart URL pin correction.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch adopt/knative-operator-1.23.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/knative-stack:pr-22-e37f663aeceab93c8240e290dc62b4bc5750244d

View Package

@patrickleet
patrickleet merged commit 4162fbe into main Sep 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant