Skip to content

fix(deps): adopt knative-operator 1.23.1 (no v-prefix) - #23

Closed
patrickleet wants to merge 1 commit into
mainfrom
fix/knative-operator-1.23.1-pin
Closed

patrickleet wants to merge 1 commit into
mainfrom
fix/knative-operator-1.23.1-pin

Conversation

@patrickleet

@patrickleet patrickleet commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Adopts knative-operator 1.23.1 with the correct pin format (no leading v).

Why

Renovate #18 proposed v1.23.1. Our render builds the chart URL as knative-v{version}/knative-operator-v{version}.tgz, so a leading v produces knative-vv1.23.1 and e2e fails.

Change

  • Pin 1.23.1 (no v)
  • Comment explaining the double-prefix trap

Relation to #18

Prefer this PR over #18. Close #18 once this is green/merged.

Test plan

  • CI validate/test/e2e green
  • Confirm helm chart URL resolves to knative-v1.23.1

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Knative Operator Helm chart to version 1.23.1.
    • Clarified chart version formatting requirements to ensure reliable downloads and end-to-end test execution.

Renovate #18 proposed v1.23.1, which double-prefixes the download URL
(knative-vv1.23.1) and fails e2e. Keep the pin as bare semver.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cc9ef418-2d0f-4fbb-a99f-b56392fa2cfb

📥 Commits

Reviewing files that changed from the base of the PR and between e3a557c and 65c04df.

📒 Files selected for processing (1)
  • functions/render/210-knative-operator.yaml.gotmpl

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Knative Operator Helm chart version changes from 1.21.0 to 1.23.1. The template documents that the pinned version must omit the leading v.

Changes

Knative Operator update

Layer / File(s) Summary
Update chart version and version format
functions/render/210-knative-operator.yaml.gotmpl
The template pins Knative Operator 1.23.1 and documents the required version format for chart URL construction.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 65c04

The chart update uses the required bare-semver format and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the dependency update to knative-operator 1.23.1 and the required omission of the v-prefix.
Linked Issues check ✅ Passed Issue #18 requires the knative-operator update from 1.21.0 to 1.23.1. The template now pins 1.23.1. The pin uses bare semver because the chart URL adds the v prefix. The added comment documents this r…
Out of Scope Changes check ✅ Passed The pull request changes only the knative-operator version pin and adds documentation directly related to the chart URL format required by issue #18. No unrelated changes are shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/knative-operator-1.23.1-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/knative-stack:pr-23-129956d05e72d6b7768d4f2993a0291db2d73a69

View Package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant