fix(deps): adopt knative-operator 1.23.1 (no v-prefix) - #23
patrickleet wants to merge 1 commit into
Conversation
Renovate #18 proposed v1.23.1, which double-prefixes the download URL (knative-vv1.23.1) and fails e2e. Keep the pin as bare semver.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Knative Operator Helm chart version changes from ChangesKnative Operator update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The chart update uses the required bare-semver format and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Published Crossplane PackageThe following Crossplane package was published as part of this PR: Package: ghcr.io/hops-ops/knative-stack:pr-23-129956d05e72d6b7768d4f2993a0291db2d73a69 |
Summary
Adopts knative-operator 1.23.1 with the correct pin format (no leading v).
Why
Renovate #18 proposed v1.23.1. Our render builds the chart URL as knative-v{version}/knative-operator-v{version}.tgz, so a leading v produces knative-vv1.23.1 and e2e fails.
Change
Relation to #18
Prefer this PR over #18. Close #18 once this is green/merged.
Test plan
Summary by CodeRabbit