fix: report snapshot controller readiness

[patrickleet]

Summary

• derive VolumeSnapshotStack.status.ready from the observed snapshot-controller Helm Release
• leave resource rendering and function-auto-ready behavior unchanged

Validation

• DOCKER_HOST=unix:///Users/patrickleet/.dory/dory.sock make render:minimal
• installed from source as dev-313712bc126e in kind-gitkb-aws-bootstrap
• live VolumeSnapshotStack/default/snapshot: status.ready=true, Synced=True, Ready=True, Responsive=True
• Production snapshot-controller v8.5.0 remains 2/2 Available and all snapshot CRDs remain Established

Linked issues

• None

Summary by CodeRabbit

• Bug Fixes
  • Status output now accurately reflects whether the snapshot controller is ready.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f8dd93e-7769-4401-b7d1-bafdd7ea24b7

📥 Commits

Reviewing files that changed from the base of the PR and between 5d8ac1f and 6e6a99d.

📒 Files selected for processing (1)

• functions/render/010-state-status.yaml.gotmpl

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The status template now sets status.ready from the observed snapshot controller readiness value.

Changes

Controller Readiness

Layer / File(s)	Summary
Render observed readiness functions/render/010-state-status.yaml.gotmpl	status.ready now reflects $state.observed.controller.ready instead of the constant false.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6e6a9

This is a localized readiness-status change with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: reporting snapshot controller readiness.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/volume-snapshot-ready-status

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/volume-snapshot-stack:pr-7-0833e7245abbedbd65559e438b59a71a28c552da

View Package