feat(pr-review): require durable smoke value evidence for example-only PRs - #3134
Merged
Conversation
…y PRs Example/walkthrough/smoke-only PRs were approved on mechanics alone (runs, deterministic, public-safe) without proving real value to the repository or product. Add a durable_smoke_value evidence requirement to the pull-request-review execution contract, mark smoke-or-example applicability with duplication and batch scans, and document the gate in the loopx-pr-review skill.
…restriction If the same author submits low-value same-shape example/smoke PRs after a REQUEST_CHANGES warning, the review must name the consequence: the owner blocks that account from further PR submissions. Adds repeat_offender_ escalation to the durable_smoke_value evidence and documents the policy in the loopx-pr-review skill.
This was referenced Aug 12, 2026
This was referenced Aug 12, 2026
huangruiteng
added a commit
that referenced
this pull request
Aug 12, 2026
huangruiteng
added a commit
that referenced
this pull request
Aug 12, 2026
#3147) Mark the fresh-project onboarding fixture done (GH-C87, #3093/#3103), bump release docs slices to v0.4.5, and add security-boundary (GH-C90) plus obligation-bound replan/evidence-read (GH-C91) fixtures. Reflect merged security fixes #3137-#3140, PR-review lenses #3123/#3134, replan evidence-log hardening #3100-#3106/#3112/#3135/#3144, and the landed React homepage #3098.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Example/walkthrough/smoke-only PRs (e.g.
examples/*.pywalkthrough smokes) were approved on mechanics alone — the script runs, is deterministic, and is public-safe — without proving real, durable value to the repository or product. This change makes that value explicit in the generic pull-request-review capability and theloopx-pr-reviewskill.Changes
loopx/capabilities/pr_review_queue/review_contract.py: newdurable_smoke_valueevidence requirement (required whensmoke_or_example_only), plus applicability flagssmoke_or_example_only,durable_smoke_value_required,duplication_scan_required,batch_pattern_scan_requiredon example/smoke-only review plans.skills/loopx-pr-review/SKILL.md: documents the gate — name the guarded shipped behavior/boundary/maintenance cost, scan existing coverage, scan the same-author batch, apply the thin/durable smoke policy, and use REQUEST_CHANGES for duplicative/oversized/value-less scaffolding.tests/capabilities/test_pr_review_contract.py: smoke-only plan requires the new evidence; runtime plans do not.examples/pr-review-command-smoke.py: contract smoke updated for the new evidence id and rule wording.Validation
python -m pytest -q tests/capabilities/test_pr_review_contract.py tests/capabilities/test_pr_review_queue.py tests/test_pr_review_github_scan.py: 26 passed.python examples/pr-review-command-smoke.py: passed (skill line budget <=180 kept).loopx check --scan-path ...on the three changed surfaces: public boundary scan clean.Why this coverage is enough
The behavior is a pure contract-shape change in one capability module with two focused unit tests (positive smoke-only and negative runtime cases), one end-to-end contract smoke, and a public-boundary scan. The skill change is documentation with a line-budget smoke already enforced by the existing smoke.