revert: restore single-session MCP client behavior - #1176
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #1175, which enables production HTTP MCP alongside the existing WebSocket lifecycle without a shared session identity. Default-capacity servers can reject
connect()when the second session is created; when capacity permits,reset/step/stateand tool calls operate on different environment instances.This restores
src/openenv/core/mcp_client.pyand its mode-selection tests exactly to #1175's parent tree while the shared-session design is resolved through RFC/transport review.Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violatedRFC Status
Test Plan
08af2d2f.git diff --check origin/main...HEADpasses.Claude Code Review
Bugbot independently reports that #1175 opens two environment sessions and fails when
max_concurrent_envs=1. The revert is the minimal release-safe action; a future shared-session implementation needs explicit RFC 003/transport-owner review and stateful async/sync E2E coverage.