chore(deps): bump huggingface/doc-builder/.github/workflows/build_pr_documentation.yml from cf20b09f274383f0d91a7055c5e43f0a2ab3d1a3 to 9f9bb430a712b5650d0e43e510656098ecdd75d4 - #1226
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Alignment Review Report
Dependabot bump of the pinned huggingface/doc-builder/.github/workflows/build_pr_documentation.yml reusable workflow: cf20b09f → 9f9bb430 (single line, build_pr_documentation.yml:13, # main retained).
Automated Checks
- Lint: PASS (N/A) —
uvisn't installed on the review VM, so.claude/hooks/lint.shexits immediately ('uv' is not installed). It's a Python-only hook that doesn't cover.github/anyway; this YAML-only diff adds no lint surface. Working tree stayed pristine. - Debug code: CLEAN —
check-debug.shhits are all pre-existingsrc/items (generic_client.pydocstringprint(...)examples,harness/collect.pyconsole.print, TODOs undercli/); none are in this diff. - YAML:
yaml.safe_loadOK.
Verification
- SHAs real + clean forward bump:
cf20b09f…9f9bb430= ahead 3 / behind 0 (clean fast-forward). New SHA == doc-buildermaintip (9f9bb430…mainidentical), so the# mainannotation is accurate. Delta = doc-builder #830 (pin checkout to the caller's pinned revision) + #790 (enable Dependabot) + #832 (harden workflow files). - Interface compat — no break: the reusable workflow's own definition changed in this delta, but only internally.
workflow_callrequired inputs are unchanged (commit_sha,pr_number,package); no new required input; nosecrets:block. OpenEnv's caller (build_pr_documentation.yml:13-18) passescommit_sha/pr_number/package: openenv/version_tag_suffix: ""— all required inputs satisfied.doc_builder_revisionlost itsdefault: "main"(it now defaults to the caller's pinned SHA viajob.workflow_sha); OpenEnv doesn't pass that input, so behavior is unchanged — strictly a hardening improvement. - Security-positive: the new revision pins the doc-builder checkout to the caller's pinned SHA (no more floating
main), addspermissions: {}+ jobcontents: read, setspersist-credentials: false, and moves${{ inputs.* }}interpolations intoenv:vars (script-injection hardening). No hardcoded credentials. - Merge state: branch is 1 commit behind
main(Miles docs #1220, which doesn't touch this file);git merge-treeagainstorigin/mainis clean and the net merge effect is exactly this 1-line bump. Non-blocking.
Open RFCs Context
rfcs/ = 000/001/002/003/005/008/012 (In Review), 010/011 (Draft), 004 (no status header, Rubrics). None govern CI / GitHub Actions / doc-build / dependency management → no RFC surface for this change.
Tier 1: Fixes Required
None.
Tier 2: Alignment Discussion
Principle Conflicts
None identified — PRINCIPLES.md / INVARIANTS.md govern the runtime API (Gym reset/step/state, MCP boundary, rewards-in-environment, client-server separation, credential exposure). A CI SHA bump touches none of them.
RFC Conflicts
None identified.
FYI (non-blocking)
- Sibling pin skew (expected): this makes
build_prlead@9f9bb430whilebuild_documentation.yml:12(build_main) andupload_pr_documentation.yml:11(upload) still sit at@cf20b09f. Dependabot tracks each reusable-workflow path separately, so temporary skew is normal and converges as the sibling PRs (or an aggregate roll-up) merge. No action needed in this single-path PR.
Summary
- 0 mechanical issues to fix
- 0 alignment points for human review
- 0 RFC conflicts
Owner for .github/ workflows + dependabot.yml: @burtenshaw.
Sent by Cursor Automation: Pre-review
| build: | ||
| if: github.event.pull_request.draft == false | ||
| uses: huggingface/doc-builder/.github/workflows/build_pr_documentation.yml@cf20b09f274383f0d91a7055c5e43f0a2ab3d1a3 # main | ||
| uses: huggingface/doc-builder/.github/workflows/build_pr_documentation.yml@9f9bb430a712b5650d0e43e510656098ecdd75d4 # main |
There was a problem hiding this comment.
Verified this bump: cf20b09f → 9f9bb430 is a clean forward bump (ahead 3 / behind 0) and 9f9bb430 == doc-builder main tip, so # main is accurate.
No break: the reusable workflow's workflow_call required inputs are unchanged (commit_sha, pr_number, package) and there's no secrets: block — this caller supplies all required inputs (version_tag_suffix is optional). doc_builder_revision dropped its default: "main" and now defaults to the caller's pinned SHA (job.workflow_sha); OpenEnv doesn't pass it, so behavior is unchanged.
Security-positive: the new revision pins the doc-builder checkout to the caller's pinned SHA instead of floating main, adds permissions: {} + job contents: read, sets persist-credentials: false, and moves inputs into env: vars (script-injection hardening).
64651ce to
4165039
Compare
…documentation.yml Bumps [huggingface/doc-builder/.github/workflows/build_pr_documentation.yml](https://github.com/huggingface/doc-builder) from cf20b09f274383f0d91a7055c5e43f0a2ab3d1a3 to 9f9bb430a712b5650d0e43e510656098ecdd75d4. - [Release notes](https://github.com/huggingface/doc-builder/releases) - [Changelog](https://github.com/huggingface/doc-builder/blob/main/RELEASE.md) - [Commits](huggingface/doc-builder@cf20b09...9f9bb43) --- updated-dependencies: - dependency-name: huggingface/doc-builder/.github/workflows/build_pr_documentation.yml dependency-version: 9f9bb430a712b5650d0e43e510656098ecdd75d4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
4165039 to
4570cf9
Compare
…-github/workflows/build_pr_documentation.yml-9f9bb430a712b5650d0e43e510656098ecdd75d4 Co-authored-by: benjamin.burtenshaw <benjamin.burtenshaw@huggingface.co>
There was a problem hiding this comment.
APPROVE at ce716062 (refreshed onto main da6c0276). This is the last of the three doc-builder pins, after #1223 and #1225.
Upstream verification
huggingface/doc-builder@9f9bb430a712b5650d0e43e510656098ecdd75d4 is the current tip of upstream main: fix(ci): harden workflow files flagged on #830 (#832).
The diff of build_pr_documentation.yml between cf20b09f and 9f9bb430 is the same hardening shape as #1225: top-level permissions: {} with per-job contents: read, every ${{ inputs.* }} moved out of run: bodies into env: variables, persist-credentials: false, and the doc-builder checkout changed from an unref'd huggingface/doc-builder to repository: ${{ job.workflow_repository }} with ref: ${{ inputs.doc_builder_revision || job.workflow_sha }}.
One behaviour change worth naming
The doc_builder_revision input default changes from "main" to empty. Previously an unset value meant the doc-builder code was pulled from the default branch regardless of the SHA we pinned in uses:; now it falls back to job.workflow_sha, so our pin governs the code as well as the YAML. build_pr_documentation.yml in this repository does not pass doc_builder_revision, so the practical effect is that PR doc builds become reproducible against the pinned revision instead of tracking upstream main. That is the intent of the change and an improvement.
Direct evidence
Unlike #1225, this workflow runs in its own PR context, so the new pin actually executed here: build / build_pr_documentation is green at this head against this repository's docs/source. That run is also the evidence I relied on when approving #1225, since the main-docs workflow cannot be exercised from a PR.
Workflow-only; not 0.6.0 package cargo. All 11 exact-head checks green and the branch is up to date with main.
Sent by Cursor Automation: Release
There was a problem hiding this comment.
Approved at ce716062.
- Exact-head checks are green, including tests, package smoke, lint, CodeQL, docs, and Bugbot.
- The net change is the verified one-line
build_pr_documentation.ymlreusable-workflow pin; its required inputs are unchanged and the upstream revision is a clean forward update. - Workflow-only: no package bytes change. If merged before the cut, draft #1211 needs one exact-main refresh/CI pass, but TestPyPI
0.6.0.dev91remains valid.
Sent by Cursor Automation: Release


Bumps huggingface/doc-builder/.github/workflows/build_pr_documentation.yml from cf20b09f274383f0d91a7055c5e43f0a2ab3d1a3 to 9f9bb430a712b5650d0e43e510656098ecdd75d4.
Changelog
Sourced from huggingface/doc-builder/.github/workflows/build_pr_documentation.yml's changelog.
Commits
9f9bb43fix(ci): harden workflow files flagged on #830 (#832)17ccdf1chore: enable Dependabot weekly GitHub Actions bumps (#790)47c6b58fix(ci): pin the doc-builder checkout to the caller's pinned revision (#830)Note
Low Risk
Single SHA bump for a documentation CI workflow with no application or security-sensitive runtime code changes.
Overview
Updates the reusable PR documentation workflow pin from
cf20b09to9f9bb43onhuggingface/doc-builder, aligning this repo with upstream CI fixes (workflow hardening and pinning doc-builder checkout to the caller’s revision).Behavior for
openenvPRs is unchanged at the inputs level (commit_sha,pr_number,package,version_tag_suffix); only which upstream workflow revision runs changes.Reviewed by Cursor Bugbot for commit ce71606. Bugbot is set up for automated code reviews on this repo. Configure here.