fix(novita): ARG longest-match + example readiness cleanup - #1234
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Prevent unbraced $BASE from corrupting $BASE_IMAGE during Dockerfile FROM rewriting, and keep wait_for_ready inside try/finally in the simple TB2 example so a readiness timeout still stops the sandbox. Post-0.6.0 follow-up; not for the Thursday release cut. Co-authored-by: benjamin.burtenshaw <benjamin.burtenshaw@huggingface.co>
12 tasks
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Post-0.6.0 follow-up (explicitly not for Thursday’s release cut) for the two latent Novita items Ben asked to track:
_resolve_from_referencesnow substitutes ARG defaults longest-name-first and matches unbraced$NAMEwith a word-boundary lookahead, soARG BASEbeforeARG BASE_IMAGEcan no longer turnFROM $BASE_IMAGEintopython:3.12_IMAGE.examples/novita_tbench2_simple.pymoveswait_for_readyinside thetry/finally, so a readiness timeout still callsstop_container.Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violatedRFC Status
Test Plan
PYTHONPATH=src:envs uv run pytest tests/test_core/test_novita_provider.py -q— 103 passed (includes newtest_resolve_unbraced_arg_does_not_prefix_longer_name)ruff check/ruff format --checkon the three changed files — cleanClaude Code Review
N/A — release-automation follow-up from Ben’s Slack ask.