Skip to content

Scope GITHUB_TOKEN permissions per job #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cursor merged 1 commit into from
Sep 23, 2026
+32 −10
Merged

Scope GITHUB_TOKEN permissions per job #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/discovery-catalog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ on:
- .github/workflows/discovery-catalog.yml
workflow_dispatch:

permissions:
contents: read

permissions: {}

@cursor cursor Bot Sep 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit: this leaves a double blank line above permissions: {} (the old top-level permissions: block was removed here). Collapsing to a single blank line keeps the style consistent. Same applies in package-ci.yml, publish-pypi.yml, publish-testpypi.yml, and validation-runtime.yml. Nothing enforces this (no yamllint/actionlint config), so it's purely cosmetic and non-blocking.


jobs:
snapshot:
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/package-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ on:
- main
workflow_dispatch:

permissions:
contents: read

permissions: {}

jobs:
package:
permissions:
contents: read
name: Build and smoke-test package
runs-on: ubuntu-latest

Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/publish-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ on:
tags:
- "v*.*.*"

permissions:
contents: read

concurrency:
group: openenv-package-publish
Expand All @@ -19,8 +17,12 @@ concurrency:
env:
PACKAGE_NAME: openenv

permissions: {}

jobs:
build:
permissions:
contents: read
name: Build release distribution
runs-on: ubuntu-latest
outputs:
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/publish-testpypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ on:
required: false
type: string

permissions:
contents: read

concurrency:
group: openenv-package-publish
Expand All @@ -22,8 +20,12 @@ concurrency:
env:
PACKAGE_NAME: openenv

permissions: {}

jobs:
build:
permissions:
contents: read
name: Build TestPyPI distribution
runs-on: ubuntu-latest
outputs:
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@ on:
env:
UV_VERSION: "0.9.3"

permissions: {}

jobs:
validate-env-locks:
permissions:
contents: read
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest

Expand Down Expand Up @@ -61,6 +65,8 @@ jobs:
done

test:
permissions:
contents: read
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -97,6 +103,8 @@ jobs:
PYTHONPATH: src:envs

test-thinkingbox-env:
permissions:
contents: read
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -131,6 +139,8 @@ jobs:
PYTHONPATH: src:envs

check-env-docs:
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand All @@ -145,6 +155,8 @@ jobs:
run: python scripts/sync_env_docs.py --check

lint:
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/validation-runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ on:
branches: [main]
workflow_dispatch:

permissions:
contents: read

permissions: {}

jobs:
runtime:
permissions:
contents: read
name: Runtime validation / Linux Docker
runs-on: ubuntu-24.04
timeout-minutes: 30
Expand Down
Loading