Capture stateful dataloader state lazily so prepare() does not draw the shuffle permutation - #4234
Open
jayzuccarelli wants to merge 2 commits into
Open
jayzuccarelli wants to merge 2 commits into
jayzuccarelli wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4204
This is the lazy capture I proposed on the issue on Sep 2.
DataLoaderAdapter.__init__callsbase_dataloader.state_dict()right after building theStatefulDataLoader. Withnum_workers > 0that builds the iterator and draws the sampler permutation atprepare()time, beforesynchronize_rng_statesruns in__iter__, so each rank shards a different epoch-0 permutation.Capture it lazily instead:
dl_state_dictstarts asNoneand_update_state_dictfills it once iteration starts.state_dict()falls back to the base dataloader if nothing was captured yet, so checkpointing before the first batch works as before.Added a single-process test (shuffle order follows the seed set after init) and a 2-process
num_workers > 0case intest_distributed_data_loop.py. Both fail on main.Before submitting
use_stateful_dataloader+num_workers>0draws epoch-0 permutation duringprepare()before cross-rank RNG sync — corrupts DDP data partition #4204Who can review?
@SunMarc