Fix metric padding removal after skip_first_batches - #4235
Open
Excelius-Wang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
skip_first_batcheswraps the batch sampler inSkipBatchSampler, which does not exposebatch_size. This makesDataLoaderShard.total_batch_sizeraise; the suppressed exception leavesremainder=-1, sogather_for_metricskeeps duplicated padding samples in the final batch.With 10 samples, two processes and a per-process batch size of 2, normal iteration gathers 10 samples. Calling
skip_first_batches(loader, 0)instead gathers 12, including duplicated samples 0 and 1.Unwrap skip samplers before reading the existing batch-size metadata, and preserve
_drop_lastwhen reconstructing the loader. This also handles nested skipping without changing sampling order.Validation
drop_last, and zero/one/nested skips.make qualityandgit diff --checkpass.GPU/TPU execution was not tested. Changes were prepared with AI assistance and reviewed by the contributor.
Before submitting