Fix skipped-step detection for AMP-aware optimizers - #4243
Open
gss10282023 wants to merge 1 commit into
Open
Conversation
Signed-off-by: gss10282023 <76646928+gss10282023@users.noreply.github.com>
3 tasks
gss10282023
marked this pull request as ready for review
September 10, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect skipped AMP-aware optimizer steps from the GradScaler scale backoff. Fused AdamW calls its Python
step()even when the kernel skips the update, so the existing call marker reports success and allows the scheduler to advance.The extra scale reads are limited to optimizers that handle AMP scaling themselves; other optimizers keep the existing detection path.
Fixes #4242.
Validation
python -m pytest -q tests/test_optimizer.py tests/test_scheduler.py: 10 passed, 2 skipped on PyTorch 2.13.0+cpu. The two skipped tests require accelerator hardware.f13f7c13for fused AdamW. It checks the parameter update, optimizer step counter, skip flag, and scheduler together, including consecutive overflows, recovery, scale growth, and unfused AdamW.git diff --check, pass for the changed files.The CUDA reproduction is documented in the linked issue; CUDA tests were not rerun on this branch.