Restore dataloader state when iteration ends early - #4248
Open
WenJing95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a validation iterator early can leave it active in
GradientState, causing the resumed training loop to skip or add optimizer updates during gradient accumulation. Runend()infinallyfor bothDataLoaderShardandDataLoaderDispatcherso closing or failing iterators restore the active training loader.Added regression coverage for update cadence and iterator cleanup; the dataloader, optimizer and scheduler tests pass on CPU (57 passed, 3 skipped).