feat: support first prepend scheme for metaspace - #2372
Merged
Conversation
SBrandeis
marked this pull request as ready for review
August 31, 2026 10:45
ArthurZucker
reviewed
Sep 2, 2026
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
are you sure we have no other way to accommodate?
Passing a cursor is prehemptive as normalizer will need them anyways to compute offsets, so would be more general / make more sense WDYT?
is_special_token only looked up self.vocab (the raw-form matcher), so an added token with special: true and normalized: true (e.g. mpnet's <unk>, distinct from the model's own [UNK]) was never recognised as special. decode(ids, skip_special_tokens=true) then failed to drop it. Found while investigating an oracle.rs divergence surfaced by rebasing feat/metaspace-prepend-first: sentence-transformers/all-mpnet-base-v2 decoding "<unk>x" with skip=true diverged from the released crate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ence-start flag Normalizer::normalize takes the byte offset of its input within the sequence. Metaspace with prepend: "first" acts when it is 0; the parallel encoder hands over chunk.range.start; every other normalizer ignores it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
SBrandeis
force-pushed
the
feat/metaspace-prepend-first
branch
from
September 11, 2026 07:16
6a3d07c to
1435813
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
prepend: "first"in Metaspacesplit: falsein MetaspaceUpdated Oracle tests