Hotfix CI: xfail the GRPO continuous batching test under DataParallel - #7422
Merged
albertvillanova merged 1 commit intoSep 28, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
Merging this PR as a CI hotfix. |
albertvillanova
deleted the
hotfix-xfail-grpo-continuous-batching-data-parallel
branch
September 28, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix:
This PR marks as
xfailthe GRPO continuous batching slow test when several accelerators are visible, whereTrainerwraps the model innn.DataParallel.Motivation
Since #7389, GRPO patches the fused LM head by binding a new
forwardto the model instance.nn.DataParallelcopies that bound method into every replica, so replica 1 still runs on the device-0 weights and the multi-GPU slow job fails:This is the same root cause as the SFT failures in #6836. See the investigation in #7421.
Solution
Apply the existing
xfail_data_parallelmarker, as done for SFT in #6841. It is conditional on more than one accelerator being visible, so the test keeps reporting normally in the single-GPU job.Changes
xfail_data_paralleltotest_train_with_transformers_continuous_batchingintests/test_grpo_trainer.pyNote
Low Risk
Test-only CI adjustment using an existing marker; no production or trainer logic changes.
Overview
Marks
test_train_with_transformers_continuous_batchingwith the shared@xfail_data_parallelmarker so CI stops failing when multiple accelerators are visible and Hugging FaceTrainerwraps the model innn.DataParallel.That path hits a known TRL limitation: GRPO’s fused LM head rebinds
forwardon one module instance, whichDataParallelreplicas mishandle (cross-device tensor errors). Single-GPU runs are unchanged—the marker only applies when more than one device is present.Reviewed by Cursor Bugbot for commit 80b1069. Bugbot is set up for automated code reviews on this repo. Configure here.