Skip to content

feat(auth)!: require an explicit callback path - #2

Merged
humandebri merged 1 commit into
mainfrom
feat/configurable-auth-callback
Aug 10, 2026
Merged

feat(auth)!: require an explicit callback path#2
humandebri merged 1 commit into
mainfrom
feat/configurable-auth-callback

Conversation

@humandebri

Copy link
Copy Markdown
Owner

Purpose

  • let native clients choose one shared HTTPS authentication callback path

Changes

  • require callbackPath when constructing the Internet Identity authenticator
  • use the configured path for authorization URLs, callback matching, and response validation
  • reject invalid and obsolete callback paths in regression tests

Verification

  • swift test
  • xcodebuild -scheme ICNativeClient -destination "generic/platform=iOS Simulator" build

Impact

  • breaking API change; callers must pass callbackPath

BREAKING CHANGE: ICInternetIdentityAuthenticator callers must provide callbackPath.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@humandebri
humandebri merged commit df66d2a into main Aug 10, 2026
3 checks passed
@humandebri
humandebri deleted the feat/configurable-auth-callback branch August 10, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant