Skip to content

Imaging-related fixes - #272

Merged
astrofrog merged 8 commits into
hyperion-rt:mainfrom
astrofrog:imaging-fixes
Aug 4, 2026
Merged

Imaging-related fixes#272
astrofrog merged 8 commits into
hyperion-rt:mainfrom
astrofrog:imaging-fixes

Conversation

@astrofrog

Copy link
Copy Markdown
Contributor

This fixes four bugs identified with the imaging:

  • Uncertainties should be calculated with sqrt(sum2) - the previous expression overestimated uncertainties
  • There were issues with orientation/wrapping for inside observers
  • There were issues with the calculation of optical depth and flux dilution for inside observers when used in combination with slabs
  • There were issues with the unit/units attributes on images/SEDs in Python

… estimator instead of a sign-flipped sample variance formula
…t is continuous in the viewing angles and honors the viewing phi angle
…dge and use the true observer distance in the inside-observer flux dilution
…roperty so that the unit attribute is initialized and validated
…nto the local spherical basis at the viewing direction
… point source positions on the all-sky map against an independent viewing-frame conversion
…ide-observer flux dilution, and the sum-of-squares uncertainty estimator
@astrofrog astrofrog added the bug label Aug 4, 2026
@astrofrog
astrofrog merged commit dbf476f into hyperion-rt:main Aug 4, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant