Fix stale schema registrations - #117
Conversation
|
I was thinking, what about the case where the file that owns the |
93bb54e to
754517a
Compare
|
Good point. It is a user mistake, but I do think we need to handle it. I think we should push diagnostics to show there's a conflict. We also need to handle recovering from that situation like you describe. It's the user's fault, but we need to recover gracefully if they do make that mistake. |
754517a to
2e637c7
Compare
2e637c7 to
4cdd8f3
Compare
|
I worked on this for a while and it got pretty complicated, so I decided to leave it for a separate PR. I'll create an issue. |
This PR fixes how workspace schemas identified by
$idget registered and unregistered in the SchemaStore$idregistrations: when a file's$idchanges or the file is deleted, its previous$idis now unregistered, even if nothing had compiled the schema yet.$idnormalization: Fragments are now removed from$idsso they don't break triggering revalidation of dependent documents.