Security: Potential prototype pollution in settings merge - #1916
Open
tomaioo wants to merge 1 commit into
Open
Conversation
In `src/background/settings.ts`, the settings object is created using spread syntax with `...rawSettings`. While this is generally safe, if `rawSettings` were ever to contain `__proto__`, `constructor`, or `prototype` keys (which could happen if the JSON file were tampered with), it could lead to prototype pollution. Additionally, the code imports raw JSON and spreads it directly. The `replace` operation on `apiUrl` also doesn't validate that `apiUrl` is actually a string before calling `.replace()`. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential prototype pollution in settings merge
Problem
Severity:
Low| File:src/background/settings.ts:L16In
src/background/settings.ts, the settings object is created using spread syntax with...rawSettings. While this is generally safe, ifrawSettingswere ever to contain__proto__,constructor, orprototypekeys (which could happen if the JSON file were tampered with), it could lead to prototype pollution. Additionally, the code imports raw JSON and spreads it directly. Thereplaceoperation onapiUrlalso doesn't validate thatapiUrlis actually a string before calling.replace().Solution
Validate the structure and types of
rawSettingsbefore spreading. UseObject.create(null)for the base object or validate that no dangerous keys exist. EnsureapiUrlis a string before calling string methods on it.Changes
src/background/settings.ts(modified)