Small wins: confirm_overwrite (#13), remove dead codec stubs (#68), drop redundant windows_ci.yml (#67)#77
Merged
Conversation
), drop redundant windows_ci.yml (#67) #13: add `confirm_overwrite`, a wrap_kvs preset that asks for typed confirmation before overwriting an existing key that holds a DIFFERENT value, plus a `mk_confirm_overwrite_preset(get_input=..., prompt=...)` factory for customizing / testing. Both exported. Declined overwrites keep the existing value. #68: remove KeyValueCodecs.key_based / .extension_based -- empty stub methods that silently returned None (No Silent Failures). They were unused; the building-block module functions remain for a future real implementation. #67: remove .github/workflows/windows_ci.yml. Windows CI already runs automatically on push/PR via ci.yml's `windows-validation` ("Windows Tests") job, so the workflow_dispatch-only file was a redundant, confusing duplicate. Closes #13 Closes #68 Closes #67 Claude-Session: https://claude.ai/code/session_01H8PmV6xmMhzV64zi1Twraw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small self-contained wins.
#13 —
confirm_overwritepreset forwrap_kvsA preset that asks for typed confirmation before overwriting an existing key holding a different value; declined overwrites keep the existing value.
Plus
mk_confirm_overwrite_preset(get_input=..., prompt=...)for customization / non-interactive policies (and testing). Both exported. 4 regression tests.#68 — remove empty
KeyValueCodecsstubskey_based/extension_basedwere empty method bodies that silently returnedNone(a No-Silent-Failures violation) and were unused. Removed; the module-level building blocks remain for a future real implementation.#67 — remove redundant
windows_ci.ymlWindows CI already runs automatically on push/PR via
ci.yml'swindows-validationjob (the green "Windows Tests" check on recent PRs). Theworkflow_dispatch-onlywindows_ci.ymlwas a redundant, confusing duplicate.Full dol suite green (135 passed). Changes are additive / dead-code removal (zero dependent blast radius;
importsanity-checked).Closes #13
Closes #68
Closes #67
https://claude.ai/code/session_01H8PmV6xmMhzV64zi1Twraw