You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I stumbled over this when trying to build against only LCIO. I have the suspicion that this went unnoticed, because something else populated this on the fly and then things worked (e.g. DD4hep creates this target, which is why we never saw it in k4geo).
I was just now trying to change the way we consume lcio from shipping an old copy to FetchContent: eudaq/eudaq#703
and stumbled over the same thing using the latest tag. Your commit partially resolves it as e.g. lcio.h is found linking just against the target LCIO::lcio but I believe it is not complete for in source builds. The include files under EVENT are not found:
[ 16%] Built target sio
Consolidate compiler generated dependencies of target lcio
[ 54%] Built target lcio
[ 54%] Building CXX object main/lib/lcio/CMakeFiles/lcio_interface.dir/src/LCEventConverter.cc.o
In file included from /home/rummler/Software/eudaq-master/main/lib/lcio/include/eudaq/LCEventConverter.hh:8,
from /home/rummler/Software/eudaq-master/main/lib/lcio/src/LCEventConverter.cc:1:
/home/rummler/Software/eudaq-master/build/_deps/extern_lcio-src/src/cpp/include/lcio.h:12:10: fatal error: EVENT/LCIO.h: No such file or directory
12 | #include "EVENT/LCIO.h"
| ^~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [main/lib/lcio/CMakeFiles/lcio_interface.dir/build.make:76: main/lib/lcio/CMakeFiles/lcio_interface.dir/src/LCEventConverter.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1692: main/lib/lcio/CMakeFiles/lcio_interface.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
target_include_directoriesof theLCIO::lciotarget to make it properly usable downstream.ENDRELEASENOTES
This is a leftover from #177 that went undiscovered until now.