Skip to content

[patch] Added appOMUpgradeMode in Facilities#2101

Merged
terc1997 merged 12 commits intomasterfrom
masref-4140
Mar 11, 2026
Merged

[patch] Added appOMUpgradeMode in Facilities#2101
terc1997 merged 12 commits intomasterfrom
masref-4140

Conversation

@sdoshi96
Copy link
Copy Markdown
Contributor

@sdoshi96 sdoshi96 commented Mar 6, 2026 •
edited
Loading

1. Description

Added a new field for Facilities - appOMUpgradeMode

2. Dependencies

3. Tests

3.1. CLI Help

image image image

3.2. Personal-FVT

FVT-run
image

⚠️ Notes for Reviewers

  • Ensure you have understood the PR guidelines in the Playbook before proceeding with a review.
  • Ensure all sections in the PR template are appropriately completed.

@sdoshi96 sdoshi96 changed the title [patch] [patch] Added appOMUpgradeMode in Facilities Mar 6, 2026
This was referenced Mar 6, 2026
Closed
Merged
@sdoshi96 sdoshi96 marked this pull request as ready for review March 6, 2026 11:19
@sdoshi96 sdoshi96 requested a review from a team as a code owner March 6, 2026 11:19
@sdoshi96 sdoshi96 added the Do not merge Don't merge this PR yet label Mar 9, 2026
@sdoshi96 sdoshi96 marked this pull request as draft March 9, 2026 06:21
@sdoshi96 sdoshi96 mentioned this pull request Mar 9, 2026
Merged
@sdoshi96 sdoshi96 marked this pull request as ready for review March 9, 2026 14:31
terc1997
terc1997 requested changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@terc1997 terc1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of the screenshots, can you run a personal FVT to verify ?

Comment thread python/src/mas/cli/templates/facilities-configs.yml.j2 Outdated
Comment thread python/src/mas/cli/gencfg.py Outdated
@sdoshi96 sdoshi96 removed the Do not merge Don't merge this PR yet label Mar 10, 2026
@sdoshi96 sdoshi96 self-assigned this Mar 10, 2026
@sdoshi96 sdoshi96 requested a review from terc1997 March 10, 2026 09:58
@sdoshi96
Copy link
Copy Markdown
Contributor Author

sdoshi96 commented Mar 10, 2026

Updated the PR with Personal FVT run link and screenshots

terc1997
terc1997 approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@terc1997 terc1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terc1997 terc1997 enabled auto-merge (squash) March 11, 2026 14:36
@terc1997 terc1997 merged commit 651f350 into master Mar 11, 2026
14 checks passed
@terc1997 terc1997 deleted the masref-4140 branch March 11, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terc1997 terc1997 terc1997 approved these changes

@dushyantbangal dushyantbangal Awaiting requested review from dushyantbangal

Assignees

@sdoshi96 sdoshi96

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sdoshi96 @terc1997