fix(obico): distinguish missing verdicts - #172
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e48e11cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
Description
Obico now distinguishes a real
safeinference from startup, idle, and failed checks. Printer cards and details never show a green Safe state until the ML service has produced an actual verdict.Related Issue
Closes #141
Documentation
Type of Change
Changes Made
unknownanderrorstates, clear stale verdicts at print boundaries, and recover to Safe only after a successful inference.Upstream comparison
Selective adaptation of
maziggy/bambuddy@06e5114a0to the refactored PrintOps printer card and permission model. Generated static bundles and unrelated changelog content were intentionally not copied.Testing
No physical printer or live Obico server was available. Startup, capture failure, rejected token/API failure, recovery, print transition, persisted-config testing, and permission redaction are covered by automated tests.
Checklist
Additional Notes
Obico remains advisory and is not treated as the primary printer safety system.