Skip to content

fix(obico): distinguish missing verdicts - #172

Merged
ichwars merged 3 commits into
mainfrom
dev-issue-141-obico-verdict-state
Sep 7, 2026
Merged

ichwars merged 3 commits into
mainfrom
dev-issue-141-obico-verdict-state

Conversation

@ichwars

@ichwars ichwars commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Closes #141

Description

Obico now distinguishes a real safe inference from startup, idle, and failed checks. Printer cards and details never show a green Safe state until the ML service has produced an actual verdict.

Related Issue

Closes #141

Documentation

  • No docs update required — this corrects existing Failure Detection status behavior without changing configuration keys or the documented setup flow.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Track per-printer unknown and error states, clear stale verdicts at print boundaries, and recover to Safe only after a successful inference.
  • Add printer-card/detail status backed by a read-only endpoint; redact internal failure reasons unless the user can read settings.
  • Persist pending Obico settings before testing the saved configuration and use the same verdict mapping in settings and printer views.
  • Add all 11 locale entries and lower the touched PrinterCard source-size budget from 2,984 to 2,980 lines.

Upstream comparison

Selective adaptation of maziggy/bambuddy@06e5114a0 to the refactored PrintOps printer card and permission model. Generated static bundles and unrelated changelog content were intentionally not copied.

Testing

  • Local backend suite: 8,604 passed, 253 skipped (5 pre-existing warnings)
  • Final targeted backend regression: 6 passed
  • Local frontend suite: 3,046 passed across 268 files; parity verified for all 11 locales
  • Focused frontend Obico/printer tests: 68 passed
  • Ruff lint/format, ESLint with zero warnings, TypeScript project build
  • Isolated Vite production build (3,089 modules)
  • Source-size budget, dependency-boundary, PrintOps domain, and protected-deletion guards

No physical printer or live Obico server was available. Startup, capture failure, rejected token/API failure, recovery, print transition, persisted-config testing, and permission redaction are covered by automated tests.

Checklist

  • My code follows the project's coding style
  • I have commented my code where necessary
  • My changes generate no new warnings
  • I have tested my changes thoroughly

Additional Notes

Obico remains advisory and is not treated as the primary printer safety system.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T06:32:59.698025Z 44e48e1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44e48e11cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/app/services/obico_detection.py
@ichwars
ichwars merged commit 63a0a70 into main Sep 7, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obico ohne gültiges Prüfergebnis nicht als Safe anzeigen

1 participant