fix(ui): make card actions accessible on touch and keyboard - #176
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
WebKit-Fokus-/Scroll-Rennfall in 2efb79b behoben: Die zusätzliche Wiederholungsprüfung zeigte, dass ein erst nach dem Menüöffnen zugestelltes Scroll-Ereignis unverändert scrollY=672 und dieselbe Ankerposition meldete. Der gemeinsame Outside-Scroll-Owner ignoriert solche alten Meldungen anhand realer Positionen; echte Außenbewegung schließt weiterhin. Kein Timer-/Cooldown-Workaround. Lokale Verifikation: 3078/3078 Tests in 273 Dateien mit Coverage, ESLint, TypeScript/Produktionsbuild, 254 JS/MJS-Dateien mit Safari-16-Syntaxbaseline, 7 Chromium-Produktionsfälle, 24 WebKit-Stabilitätsprüfungen und README-Smoke auf zwei Viewports. Source-Budget für 1787 Dateien und Dependency-Boundaries bestanden. npm audit: 0. Regressionen committed; Folgepatch inline geprüft, keine Sub-Agenten. GitHub auf genau diesem Head bestätigt inzwischen dieselben 3078 Frontend-Tests, alle 7 Chromium-Produktionsfälle, beide README-Smokes und den Safari-16-Syntaxcheck. CodeQL, Security-Audits und PostgreSQL-Prüfung sind ebenfalls grün. Der abschließende Produktionscontainer-Lauf steht noch aus; Merge erst nach vollständig grüner CI. Nutzeränderungen unter static/ sind unverändert und nicht Bestandteil des PR. |
Summary
Closes #145.
Issue and scope review
Fresh GitHub review: #145 remains applicable; this PR closes only #145. #126/#150 retain their hardware-validation boundary. Other open issues are not claimed solved.
Selected upstream references: 90fac7b and a72f49b, adapted to PrintOps owners rather than cherry-picked wholesale.
Documentation
Permanent in-repo guide:
docs/touch-and-keyboard-controls.md, linked from docs index; CHANGELOG updated.The CONTRIBUTING-linked separate wiki repository was unavailable in the preceding docs check (404), so the matching documentation is included here. No marketing/version changes.
Verification on 2efb79b
Integration safety
All work performed inline, without subagents or new worktrees. Only 26 task-owned paths committed; no static files staged.
FileManager and Archives size allowances were tightened after removing obsolete logic. Existing coordinate ContextMenu remains the separate owner for coordinate/submenu interactions; ActionMenu handles flat anchored controls.
Initial automated review of 1333333 completed without findings; the six-path scroll follow-up was reviewed inline. All 24 GitHub jobs passed on the final head: CI (17), CodeQL (3), Security Audit (4). CI independently confirmed 3078 frontend tests, 7 production Chromium cases, both README smoke viewports and the 254-file Safari-16 syntax scan. Backend tests: 8710 passed across host shards, 8694 across Docker shards; final production-container integration: 2950 passed, 171 skipped, 4 warnings (820.37s). No unresolved review threads. Merge authorized only for this exact tested head. Physical devices and assistive-technology combinations beyond the browser simulations are not claimed tested.