fix: show missing section warnings on schedule load

[ronaldw07]

Summary

Fixes #1399 - Show missing section warnings for saved courses on page load

When AntAlmanac loads and restores courses from fromScheduleSaveState, the app now detects and displays warnings for courses that are missing required sections (e.g., lab, discussion).

Changes

• Added checkForMissingSections() method to AppStore that:
  • Groups courses by course ID (deptCode + courseNumber + term)
  • Compares required section types (from sectionTypes array) with enrolled section types
  • Identifies missing required sections
  • Displays a warning snackbar listing all affected courses
• Integrated into schedule loading: Call checkForMissingSections() after successful schedule load in loadSchedule()
• Extracted sectionTypeToName() utility function: Created a reusable utility to convert section type codes to readable names
• Refactored getMissingSections.ts: Updated to use the shared utility function, eliminating code duplication

How It Works

The getCourseInfo API endpoint (called by fromScheduleSaveState) already returns the full sectionTypes array containing all available section types for a course. After a schedule loads successfully, checkForMissingSections() compares the required section types with the sections the user has enrolled in and displays warnings for any missing required sections.

Example Output

If a user has saved a schedule with only Lecture + Lab sections of a course that requires Lecture + Lab + Discussion, they'll see:

1 course is missing required sections:
COMPSCI 161 (2024 Fall): Missing Discussion

For multiple courses:

2 courses are missing required sections:
COMPSCI 161 (2024 Fall): Missing Discussion
PHYSICS 7C (2024 Fall): Missing Lab

Test plan

• Load a saved schedule with courses missing required sections
• Verify warning snackbar appears on page load
• Verify warning message correctly identifies missing sections
• Verify existing missing section warnings in the AddedCourses pane still work
• Verify no warnings appear for courses with all required sections

[calebwongg]

Haven't looked too deep into the code yet, but upon just checking to see if the feature works, we still aren't displaying the missing sections warning when the user loads in their schedule

This is the what my added courses pane looks like right when I load in my classes, and if the user saved an incomplete schedule, we have no missing sections warning. We want to have the warning display right when the schedule loads in. Feel free to text me on discord (calbe__) if you have any further questions!

[calebwongg]

We want to keep the warning consistent, so instead of the snackbar we want to use the mui alert. You shouldn't need to code in the alert because we already have it in SectionTable.tsx:

            {missingSections?.length > 0 && (
                <Alert
                    severity="warning"
                    sx={{
                        mb: 1,
                        '& .MuiAlert-message': {
                            display: 'flex',
                            alignItems: 'center',
                        },
                    }}
                >
                    Missing required sections: {missingSections.join(', ')}
                </Alert>
            )}

[calebwongg]

Look into how the missing sections attributes flow through the code. We store the missing sections as a property on CourseWithTerm objects and check that value when the section table mounts. Feel free to reach out if you have questions

[calebwongg]

issue: Again haven't looked into the code, but now we are staying consistent with the mui alert and there is some sort of missing sections comparison going on upon schedule load (which is good).

However, the comparison doesn't work as it thinks that some classes require sections that don't exist for that class.

An example is that EECS 31 doesn't require a lab or seminar. The warning should only be displaying for the lab

[calebwongg]

nit: websoc lets you query with an array of section codes. Its redundant here to have an individual query for each section code. We would rather only need one query using an array of section codes as the query parameter.

[ronaldw07]

oh I see. I will try to fix it

[calebwongg]

sounds good thank you !!!

[ronaldw07]

let me know if this works!

[calebwongg]

issue: Still didn't get into the bulk of the code, but some functionality is still a little buggy! You can see here that I'm getting an alert for a missing lab when MATH 3A has no lab section:

Another thing worth looking into also is that auth is substantially slower when loading in the app. It also seems a bit slower switching between the 'SEARCH' pane and the 'ADDED' pane (this could just be placebo). I'm suspecting it might still be because of redundant API queries, so try and look into it and see what you can do. If you run into any problems, or if you have any questions on how to implement this fix feel free to reach out! Please test before marking ready for review!

[ronaldw07]

Fixed the false positive warnings. The previous dept-wide query was returning courses from other departments with the same course number (e.g. PHYSICS 3A and SOC SCI 3A contaminating MATH 3A's sectionTypes with Lab). Now queries each course individually by (term, deptCode, courseNumber) and filters results to only the matching department and course number. Tested locally - MATH 3A with only lecture correctly shows 'Missing: Discussion' and no false Lab warning.

[calebwongg]

feature looks good ! some small changes though, the main one being to change the idea of building our own keys with '|'

[ronaldw07]

addressed all the nits from Feb 25 (hopefully) — switched to a nested Map<Term, Map<Dept, Map<CourseNum, SectionTypes>>> instead of building synthetic string keys, used WebsocSectionType directly for the set type, and removed the redundant dept/courseNumber filter checks inside the loop.

[cubic-dev-ai]

No issues found across 3 files