Use cgi/escape instead of full cgi library - #95
Merged
Conversation
Ruby 4.0 removed the bundled CGI gem, causing a warning when `require 'cgi'` is used. The cgi/escape module has been available since Ruby 2.0 and provides only CGI.escape and CGI.unescape, which is all this file needs.
There was a problem hiding this comment.
Pull request overview
This PR updates Hawk’s HTTP instrumentation to avoid requiring Ruby’s full cgi library (which emits warnings on Ruby 4.0 due to CGI being extracted from stdlib), while still supporting URL escaping/unescaping used for log output.
Changes:
- Replaces
require 'cgi'with a narrower require intended to only load escaping helpers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tagliala
force-pushed
the
fix/ruby-4-cgi-warning
branch
from
July 27, 2026 14:13
4a5d0b5 to
d112ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 4.0 removed the bundled CGI gem, causing a warning when
require 'cgi'is used. The cgi/escape module has been available since Ruby 2.0 and provides only CGI.escape and CGI.unescape, which is all this file needs.