Skip to content

gRPC datastore and search provider for Komet - #220

Merged
pChou19 merged 5 commits into
mainfrom
feature/grpc_plugin
Aug 12, 2026
Merged

gRPC datastore and search provider for Komet#220
pChou19 merged 5 commits into
mainfrom
feature/grpc_plugin

Conversation

@pChou19

@pChou19 pChou19 commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of the grpc_plugin workspace feature, spanning 6 repositories. All of them must merge for the feature to be complete.

Component Pull request
tinkar-core ← this PR #220
komet-grpc-plugin icaglobal/komet-grpc-plugin#1
komet ikmdev/komet#887
tinkar-service icaglobal/tinkar-service#9
komet-claude-plugin knowledge-graphlet/komet-claude-plugin#6
komet-desktop ikmdev/komet-desktop#131

Opened by ws:feature-pr-publish.

This was referenced Aug 4, 2026
Merged
Merged
Merged
Merged
@pChou19

pChou19 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Testing new workspace goals, do not merge

@pChou19 pChou19 mentioned this pull request Aug 7, 2026
Merged
knowledge-graphlet pushed a commit that referenced this pull request Aug 12, 2026
@kec @pChou19
common: add the gRPC service surface (NoLocalUserStore, RemoteConcept…
7bf77d5 
…SearchService)

API surface from Patrick Chou's gRPC work (ikmdev/tinkar-core PR #220,
commit bd9de7e), landed byte-exact so komet-grpc-plugin main compiles
against tinkar-core main. The provider registrations and enablement in
that PR remain with it and rebase to the runtime remainder.

Co-authored-by: Patrick Chou <1326306+pChou19@users.noreply.github.com>
Fixes: IKE-Network/ike-issues#991
This was referenced Aug 12, 2026
Open
Closed
@knowledge-graphlet

knowledge-graphlet commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Status from the ike-komet-wsr side, where we've been landing this PR's pieces incrementally on main (with your authorship credited on each commit):

  • 7bf77d59 — the two common.service interfaces (NoLocalUserStore, RemoteConceptSearchService), byte-exact from this PR. komet-grpc-plugin main compiles against tinkar-core main, and the plugin is now staged into komet-desktop's plugin layer — the gRPC data-source option shows in the startup dialog.
  • e0b98eb6 — the EntityProvider absent-entity tolerance and the Searcher LIDR-absent guards, landed as general sparse-dataset robustness.

That leaves exactly ten files in this PR: the legacy META-INF/services registrations for tinkar-core's own providers (SpinedArray controllers, EntityProvider/StampProvider lifecycles, PathProvider, executor, alert, search). A suggestion on those: module-path consumers (Komet desktop) already discover these providers through module-info provides, so the registrations only serve classpath-mode consumers — which in this stack means tinkar-service. Our precedent for that situation is the classpath consumer shipping the registrations in its own resources (ike-knowledge-provider carries the engine controllers' service files itself for exactly this reason), which keeps tinkar-core free of consumer-specific discovery shims. If you move the ten files into tinkar-service, this PR empties and can close, and nothing on the tinkar-core side blocks the gRPC runtime.

Happy to help wire the tinkar-service side if useful.

@pChou19
pChou19 merged commit 8eb9f33 into main Aug 12, 2026
1 of 4 checks passed
@pChou19
pChou19 deleted the feature/grpc_plugin branch August 12, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pChou19 @knowledge-graphlet