postprocess: Add cronjob test c2rust-postprocess#1857
Conversation
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
from
84808f3 to
3a95eb4
Compare
thedataking
changed the title
thedataking
changed the title
| - name: Set postprocess cache policy | ||
| run: echo "C2RUST_POSTPROCESS_ARGS=--on-error warn" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Nit: description does not match what step actually does does.
Nit: why are you not using the env key like you do on line 151?
you should add a short comment noting why we don't want postprocessor errors to be fatal except outside the cronjob.
|
|
||
| env: | ||
| GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }} | ||
| C2RUST_POSTPROCESS_ARGS: --on-error warn |
There was a problem hiding this comment.
I assume this is temporary? Once key is set, we want keep-going (the default, so no need to set it)?
thedataking
left a comment
thedataking
left a comment
There was a problem hiding this comment.
Missing: using the Github cache action to restore and save c2rust-postprocessor entries on the cronjob or PR runs. If that's why the PR is marked draft, no worries.
| ${{ github.workspace }}/tests/integration/tests/refactor-diffs/** | ||
| if: always() | ||
|
|
||
| postprocess-test: |
There was a problem hiding this comment.
Lines 5-10 control when this workflow runs. Should this go in a separate file (ci-postprocess.yml?)
You'll need to investigate how this affects caching ... not just for the postprocessor cache entries but also how it works with Swatinem/rust-cache@v2 and awalsh128/cache-apt-pkgs-action@latest.
There was a problem hiding this comment.
I'm using internal-testsuite.yml for testing, since github requires a workflow to be on master before I can launch any jobs. Currently, postprocess-test will run on push, which is fine for this.
Keeping this open for when I make that change.
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
2 times, most recently
from
24ae5c6 to
1d7e507
Compare
|
Most of this is pretty hacked together, I'll address feedback as it stabilizes. |
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
from
1d7e507 to
226bb76
Compare
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
from
d111911 to
c5d51a4
Compare
Crocodoctopus
force-pushed
the
bg/add-postprocess-ci-test
branch
from
c5d51a4 to
a19e69c
Compare
2 participants
Test PR
c2rust-postprocesstesting in CI.The basic idea is to run a daily cronjob running
c2rust-postprocessonjson-cwith a real API key and with--on-error keep-going, generating new cache entries. PR CI runners will run their postprocess tests with under cache only with--on-error warn. This will have the side effect that breaking changes toc2rust-postprocessthat still work under--on-error warnwill only become apparent during the daily cronjob.