Fix libgit2 reorganize-definitions bug#1859
Open
randomPoison wants to merge 2 commits into
Open
Conversation
Previously only idents used in the function body were accounted for, which led to errors if there was a type referenced in the signature but not the body.
thedataking
force-pushed
the
legare/libgit2-refactor-bug
branch
from
3e58e59 to
cff2ba5
Compare
ahomescu
approved these changes
Jun 17, 2026
ahomescu
reviewed
Jun 17, 2026
| used_idents.insert(segment.ident); | ||
| } | ||
| }); | ||
| collect_used_idents(item); |
Contributor
There was a problem hiding this comment.
This is an extra refactoring that wasn't really necessary, I think the fix could have been one line. I don't hate the new code though, so let's land it as is.
thedataking
approved these changes
Jun 18, 2026
Contributor
|
Is this ready to land? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libgit2 surfaced a bug in reorganize-definitions where if a type was referenced only in a functions's signature (but not its body), reorganize-definitions would fail to emit an import for that type. The fix seems simple, just account for types used by the function signature.