transpile: Ensure that there are always types for primitive type kinds#1865
Open
Rua wants to merge 1 commit into
Open
transpile: Ensure that there are always types for primitive type kinds#1865Rua wants to merge 1 commit into
Rua wants to merge 1 commit into
Conversation
ahomescu
approved these changes
Jun 19, 2026
| self.visit_node(untyped_context, node_id, new_id, expected_ty) | ||
| } | ||
|
|
||
| // Check what primitive kinds were emitted by the compiler. |
Contributor
There was a problem hiding this comment.
Nit: this could be moved up just before PULLBACK_KINDS, for consistency with the order from mod.rs (and IMHO handling the primitives first then the pullbacks makes sense).
Contributor
Author
There was a problem hiding this comment.
It can't be, because it relies on c_types being filled by the main node processing code right above it first. If it's moved, then c_types will still be empty. The idea here was to add these types only if the compiler didn't already provide them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows code elsewhere to rely on these kinds always existing, for calling
type_for_kindand the like. This can be expanded to include more types in the future if needed.