Skip to content

update immutable, fix npm references - #3

Open
calebleavell wants to merge 1 commit into
masterfrom
fix/TP-21581-bump-scribe-7267094957
Open

update immutable, fix npm references#3
calebleavell wants to merge 1 commit into
masterfrom
fix/TP-21581-bump-scribe-7267094957

Conversation

@calebleavell

Copy link
Copy Markdown

Updates the immutable package to fix a CVE. However, the package no longer distributes updates in the way that bower supports, so that required a change to the places where immutable is used to grab it from npm instead.

https://thryv.atlassian.net/browse/TP-21581

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project to use Immutable.js v4 from npm (instead of the bower distribution) to address a reported CVE and keep build/example wiring functional with the new distribution approach.

Changes:

  • Bumps immutable dependency to ^4.3.9 and updates the pinned resolution.
  • Switches RequireJS/build path mappings from bower_components/immutable to node_modules/immutable/dist/immutable.
  • Removes immutable from bower.json dependencies.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Plumbing.js Updates build-time RequireJS path for immutable to read from node_modules.
Gruntfile.js Updates RequireJS build config to source immutable from node_modules.
package.json Upgrades Immutable.js to v4 and updates resolutions accordingly.
bower.json Removes immutable from bower-managed dependencies.
examples/raw.html Updates example RequireJS path for immutable to node_modules.
examples/raw-inline.html Updates example RequireJS path for immutable to node_modules.
examples/no-undo-manager.html Updates example RequireJS path for immutable to node_modules.
examples/build.html Updates example RequireJS path for immutable to node_modules.
examples/amd.html Updates example RequireJS path for immutable to node_modules.
examples/amd-inline.html Updates example RequireJS path for immutable to node_modules.
examples/build-cjs.sh Updates Browserify immutable reference to node_modules.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread examples/build-cjs.sh
Comment on lines 4 to +8
bower install
npm install deamdify
npm install scribe-plugin-toolbar
browserify -g deamdify \
-r ./bower_components/immutable/dist/immutable.js:immutable \
-r ./node_modules/immutable/dist/immutable.js:immutable \
Comment thread bower.json
Comment on lines 1 to 5
{
"name": "scribe",
"dependencies": {
"immutable" : "3.8.1"
},
"devDependencies": {
"requirejs": "~2.1.9",
"scribe-plugin-blockquote-command": "guardian/scribe-plugin-blockquote-command#master",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants