update immutable, fix npm references - #3
Open
calebleavell wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project to use Immutable.js v4 from npm (instead of the bower distribution) to address a reported CVE and keep build/example wiring functional with the new distribution approach.
Changes:
- Bumps
immutabledependency to^4.3.9and updates the pinned resolution. - Switches RequireJS/build path mappings from
bower_components/immutabletonode_modules/immutable/dist/immutable. - Removes
immutablefrombower.jsondependencies.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Plumbing.js | Updates build-time RequireJS path for immutable to read from node_modules. |
| Gruntfile.js | Updates RequireJS build config to source immutable from node_modules. |
| package.json | Upgrades Immutable.js to v4 and updates resolutions accordingly. |
| bower.json | Removes immutable from bower-managed dependencies. |
| examples/raw.html | Updates example RequireJS path for immutable to node_modules. |
| examples/raw-inline.html | Updates example RequireJS path for immutable to node_modules. |
| examples/no-undo-manager.html | Updates example RequireJS path for immutable to node_modules. |
| examples/build.html | Updates example RequireJS path for immutable to node_modules. |
| examples/amd.html | Updates example RequireJS path for immutable to node_modules. |
| examples/amd-inline.html | Updates example RequireJS path for immutable to node_modules. |
| examples/build-cjs.sh | Updates Browserify immutable reference to node_modules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
4
to
+8
| bower install | ||
| npm install deamdify | ||
| npm install scribe-plugin-toolbar | ||
| browserify -g deamdify \ | ||
| -r ./bower_components/immutable/dist/immutable.js:immutable \ | ||
| -r ./node_modules/immutable/dist/immutable.js:immutable \ |
Comment on lines
1
to
5
| { | ||
| "name": "scribe", | ||
| "dependencies": { | ||
| "immutable" : "3.8.1" | ||
| }, | ||
| "devDependencies": { | ||
| "requirejs": "~2.1.9", | ||
| "scribe-plugin-blockquote-command": "guardian/scribe-plugin-blockquote-command#master", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the immutable package to fix a CVE. However, the package no longer distributes updates in the way that bower supports, so that required a change to the places where immutable is used to grab it from npm instead.
https://thryv.atlassian.net/browse/TP-21581