style: fix error [SIM118] - Use key in dict instead of key in dict.keys().

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>

Author: pvital

src/instana/agent/host.py

@@ -123,10 +123,7 @@ def can_send(self) -> bool:
             logger.debug("Fork detected; Handling like a pro...")
             self.handle_fork()
 
-        if self.machine.fsm.current in ["wait4init", "good2go"]:
-            return True
-
-        return False
+        return self.machine.fsm.current in ["wait4init", "good2go"]
 
     def set_from(
         self,
@@ -371,7 +368,7 @@ def filter_spans(self, spans: List[Dict[str, Any]]) -> List[Dict[str, Any]]:
             service_name = ""
 
             # Set the service name
-            for span_value in span.data.keys():
+            for span_value in span.data:
                 if isinstance(span.data[span_value], dict):
                     service_name = span_value
 
@@ -413,13 +410,12 @@ def __is_endpoint_ignored(self, span_attributes: dict) -> bool:
 
         # Check exclude rules
         exclude_rules = filters.get("exclude", [])
-        if any(
-            matches_rule(rule.get("attributes", []), span_attributes)
-            for rule in exclude_rules
-        ):
-            return True
-
-        return False
+        return bool(
+            any(
+                matches_rule(rule.get("attributes", []), span_attributes)
+                for rule in exclude_rules
+            )
+        )
 
     def handle_agent_tasks(self, task: Dict[str, Any]) -> None:
         """

src/instana/instrumentation/aws/dynamodb.py

@@ -23,7 +23,7 @@ def create_dynamodb_span(
         try:
             span.set_attribute("dynamodb.op", args[0])
             span.set_attribute("dynamodb.region", instance._client_config.region_name)
-            if "TableName" in args[1].keys():
+            if "TableName" in args[1]:
                 span.set_attribute("dynamodb.table", args[1]["TableName"])
         except Exception as exc:
             span.record_exception(exc)

src/instana/instrumentation/aws/s3.py

@@ -35,7 +35,7 @@ def create_s3_span(
         with tracer.start_as_current_span("s3", context=parent_context) as span:
             try:
                 span.set_attribute("s3.op", args[0])
-                if "Bucket" in args[1].keys():
+                if "Bucket" in args[1]:
                     span.set_attribute("s3.bucket", args[1]["Bucket"])
             except Exception as exc:
                 span.record_exception(exc)

src/instana/util/config.py

@@ -1,7 +1,7 @@
 # (c) Copyright IBM Corp. 2025
 
 import os
-from typing import Any, Dict, List, Sequence, Tuple, Union, Optional
+from typing import Any, Dict, List, Optional, Sequence, Tuple, Union
 
 from instana.configurator import config
 from instana.log import logger
@@ -317,7 +317,7 @@ def parse_span_disabling_str(item: str) -> List[str]:
     @param item: String span disabling configuration
     @return: List of disabled spans
     """
-    if item.lower() in SPAN_CATEGORIES or item.lower() in SPAN_TYPE_TO_CATEGORY.keys():
+    if item.lower() in SPAN_CATEGORIES or item.lower() in SPAN_TYPE_TO_CATEGORY:
         return [item.lower()]
     else:
         logger.debug(f"set_span_disabling_str: Invalid span category/type: {item}")
@@ -335,7 +335,7 @@ def parse_span_disabling_dict(items: Dict[str, bool]) -> Tuple[List[str], List[s
     enabled_spans = []
 
     for key, value in items.items():
-        if key in SPAN_CATEGORIES or key in SPAN_TYPE_TO_CATEGORY.keys():
+        if key in SPAN_CATEGORIES or key in SPAN_TYPE_TO_CATEGORY:
             if is_truthy(value):
                 disabled_spans.append(key)
             else:
@@ -394,9 +394,10 @@ def get_disable_trace_configurations_from_yaml() -> Tuple[List[str], List[str]]:
 
 
 def get_disable_trace_configurations_from_local() -> Tuple[List[str], List[str]]:
-    if "tracing" in config:
-        if tracing_disable_config := config["tracing"].get("disable", None):
-            return parse_span_disabling(tracing_disable_config)
+    if "tracing" in config and (
+        tracing_disable_config := config["tracing"].get("disable", None)
+    ):
+        return parse_span_disabling(tracing_disable_config)
     return [], []
 
 
@@ -472,15 +473,15 @@ def parse_technology_stack_trace_config(
     tech_stack_config = {}
     context = f"for {tech_name}" if tech_name else ""
 
-    if level_key in tech_data:
-        if validated_level := validate_stack_trace_level(tech_data[level_key], context):
-            tech_stack_config["level"] = validated_level
+    if level_key in tech_data and (
+        validated_level := validate_stack_trace_level(tech_data[level_key], context)
+    ):
+        tech_stack_config["level"] = validated_level
 
-    if length_key in tech_data:
-        if validated_length := validate_stack_trace_length(
-            tech_data[length_key], context
-        ):
-            tech_stack_config["length"] = validated_length
+    if length_key in tech_data and (
+        validated_length := validate_stack_trace_length(tech_data[length_key], context)
+    ):
+        tech_stack_config["length"] = validated_length
 
     return tech_stack_config
 
@@ -498,17 +499,19 @@ def parse_global_stack_trace_config(global_config: Dict[str, Any]) -> Tuple[str,
     level = "all"
     length = 30
 
-    if "stack-trace" in global_config:
-        if validated_level := validate_stack_trace_level(
+    if "stack-trace" in global_config and (
+        validated_level := validate_stack_trace_level(
             global_config["stack-trace"], "in YAML config"
-        ):
-            level = validated_level
+        )
+    ):
+        level = validated_level
 
-    if "stack-trace-length" in global_config:
-        if validated_length := validate_stack_trace_length(
+    if "stack-trace-length" in global_config and (
+        validated_length := validate_stack_trace_length(
             global_config["stack-trace-length"], "in YAML config"
-        ):
-            length = validated_length
+        )
+    ):
+        length = validated_length
 
     return level, length
 
@@ -544,9 +547,9 @@ def parse_tech_specific_stack_trace_configs(
     return tech_config
 
 
-def get_stack_trace_config_from_yaml() -> (
-    Tuple[str, int, Dict[str, Dict[str, Union[str, int]]]]
-):
+def get_stack_trace_config_from_yaml() -> Tuple[
+    str, int, Dict[str, Dict[str, Union[str, int]]]
+]:
     """
     Get stack trace configuration from YAML file specified by INSTANA_CONFIG_PATH.
 

tests/clients/test_redis.py

@@ -26,7 +26,7 @@ def _resource(self) -> Generator[None, None, None]:
         self.client = redis.Redis(host=testenv["redis_host"], db=testenv["redis_db"])
         yield
         keys_to_remove = [
-            k for k in os.environ.keys() if k.startswith("INSTANA_TRACING_FILTER_")
+            k for k in os.environ if k.startswith("INSTANA_TRACING_FILTER_")
         ]
         for k in keys_to_remove:
             del os.environ[k]

tests/propagators/test_http_propagator.py

@@ -318,15 +318,15 @@ def test_w3c_off_x_instana_l_0(
         assert not span_ctx.correlation_id
 
         # Assert that the traceparent is propagated when it is enabled
-        if "traceparent" in carrier_header.keys():
+        if "traceparent" in carrier_header:
             assert span_ctx.traceparent
             tp_trace_id = header_to_long_id(carrier_header["traceparent"].split("-")[1])
         else:
             assert not span_ctx.traceparent
             tp_trace_id = span_ctx.trace_id
 
         # Assert that the tracestate is propagated when it is enabled
-        if "tracestate" in carrier_header.keys():
+        if "tracestate" in carrier_header:
             assert span_ctx.tracestate
         else:
             assert not span_ctx.tracestate
@@ -352,7 +352,7 @@ def test_w3c_off_x_instana_l_0(
         )
 
         # Assert that the tracestate is propagated when it is enabled
-        if "tracestate" in carrier_header.keys():
+        if "tracestate" in carrier_header:
             assert "tracestate" in downstream_carrier
             assert carrier_header["tracestate"] == downstream_carrier["tracestate"]