fix(migtd): resolve compiler warnings across crates#900
Merged
Conversation
sgrams
force-pushed
the
fix/compiler-warnings
branch
from
0293d9e to
9ff73a4
Compare
Fix all warnings emitted during a default feature build: - attestation: replace `use super::*` with a cfg-gated `use super::QveCollateral` in attest_lib_binding, since QveCollateral is only referenced under the attest-lib-ext feature. - migtd/servtd_ext: add missing `#[cfg(test)]` attribute to the `mod test` block, consistent with every other test module in the codebase, silencing the unused-import lint on `ServtdExt`. - migtd/session: gate the `log_request_error!` macro definition behind `#[cfg(feature = "vmcall-raw")]` since all call-sites live inside vmcall-raw-only functions; remove spurious `mut` from the `transport` binding (value is consumed by-move, never reassigned). - migtd/transport: prefix both `mig_request_id` parameters with `_` (`_mig_request_id`) in `setup_transport` and `shutdown_transport`; the parameter is only read inside cfg-gated blocks so it appears unused when those features are disabled. - migtd/main: rename `data` / `mut data` to `mut _data` and update all references; the buffer is only passed into vmcall-raw and policy_v2 code paths, making it appear unused in other configurations. Signed-off-by: Stanislaw Grams <stanislaw.grams@intel.com>
sgrams
force-pushed
the
fix/compiler-warnings
branch
from
9ff73a4 to
ef80ad8
Compare
MichalTarnacki
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix all warnings emitted during a default feature build