fix(migtd): verify info_hash instead of servtd_hash#902
Merged
Conversation
The old verify_servtd_hash computed SHA384(info_hash || type || attr) and compared to init_servtd_hash. Per GHCI spec, the correct check is to compare SHA384(masked_tdinfo) directly against init_servtd_info_hash, removing the unnecessary extra hash layer. Also renames verify_servtd_hash to verify_servtd_info_hash for clarity. Co-developed-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
Contributor
Author
Contributor
|
OK. It seems misunderstanding on SERVTD_HASH v.s. SERVTD_INFO_HASH.
I think we should use SERVTD_INFO_HASH to validate INIT_INFO_HASH. |
jyao1
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old verify_servtd_hash computed SHA384(info_hash || type || attr) and compared to init_servtd_hash. Per GHCI spec, the correct check is to compare SHA384(masked_tdinfo) directly against init_servtd_info_hash, removing the unnecessary extra hash layer.
Also renames verify_servtd_hash to verify_servtd_info_hash for clarity.
Co-developed-by: Copilot 223556219+Copilot@users.noreply.github.com