[SYCL] Deprecate legacy info::kernel descriptors - #22520
Conversation
| struct function_name : kernel_traits<UR_KERNEL_INFO_FUNCTION_NAME> { | ||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| struct __SYCL_DEPRECATED( | ||
| "info::kernel::function_name is a legacy descriptor not part of SYCL " |
There was a problem hiding this comment.
I doubt we should explain that it is a legacy descriptor here. usually we just say that something is deprecated.
@dm-vodopyanov can you please guide us here?
There was a problem hiding this comment.
@KseniyaTikhomirova @dm-vodopyanov what wording would be good here from your POV?
There was a problem hiding this comment.
"smth is deprecated." If there is any replacement - then specify what it is. I usually use our code as example, see https://github.com/intel/llvm/blob/sycl/sycl/include/sycl/sub_group.hpp#L111
d6e8473 to
7af6a9c
Compare
|
@crystarm could you please resolve format & pre-commit issues |
KornevNikita
left a comment
KornevNikita
left a comment
There was a problem hiding this comment.
Some E2E also need "__INTEL_PREVIEW_BREAKING_CHANGES" guards, see the self-build jobs
…ards for deprecated kernel info
|
@crystarm could you please resolve merge conflict? can't start pre-commit with the conflict |
|
Pushed a follow-up addressing the remaining review comments:
|
KornevNikita
left a comment
KornevNikita
left a comment
There was a problem hiding this comment.
@crystarm could you please resolve the merge conflict
cbff67e to
ab23bd2
Compare
ab23bd2 to
b71fd4d
Compare
3 participants
Fixes #22505.
Deprecate three undocumented legacy
info::kerneldescriptors that are not part of SYCL 2020:info::kernel::function_nameinfo::kernel::reference_countinfo::kernel::contextEach descriptor is now annotated with
__SYCL_DEPRECATED(...)and guarded by#ifndef __INTEL_PREVIEW_BREAKING_CHANGES, following the same pattern asinfo::platform::profileandinfo::device::atomic64.