[SYCL] Update E2E to use access_mode [3/3] - #22844
Open
KornevNikita wants to merge 4 commits into
Open
Conversation
access::mode is deprecated in favor of access_mode. PR to add deprecations: intel#22803 1st - intel#22842 2nd - intel#22843
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is the final part of a series updating SYCL end-to-end tests to use sycl::access_mode (and related aliases) instead of the deprecated sycl::access::mode, aligning the test suite with the upcoming deprecation work referenced in the PR description.
Changes:
- Replaced
access::mode::*usages inbuffer/imageget_accesscalls withaccess_mode::*(orsycl::access_mode::*) across many E2E tests. - Updated accessor type spellings (
sycl::accessor<..., access_mode::...>) and related constexpr aliases to consistently useaccess_mode. - Adjusted a few FileCheck source-location expectations where line layout changed.
Reviewed changes
Copilot reviewed 106 out of 106 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/test-e2e/XPTI/kernel/content.cpp | Switch get_access template args to access_mode. |
| sycl/test-e2e/XPTI/buffer/sub_buffer.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/multiple_buffers.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/accessors.cpp | Switch accessor mode to sycl::access_mode and update FileCheck location expectations. |
| sycl/test-e2e/WorkGroupStatic/work_group_static_memory_block_scope.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/WorkGroupScratchMemory/dynamic_alloc_local_accessor.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/USM/memcpy.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/USM/fill.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/SubGroupMask/GroupSize.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/SubGroup/scan.hpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/generic_reduce.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/barrier.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/SpecConstants/2020/non_native/Inputs/common.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/SpecConstants/2020/handler-api.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Scheduler/MemObjRemapping.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Scheduler/DeleteCmdException.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Scheduler/BasicSchedulerTests.cpp | Switch alias from sycl::access::mode to sycl::access_mode. |
| sycl/test-e2e/Sampler/unnormalized-clampedge-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-clamp-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-none-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-mirror-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-clamp-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/basic-rw-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Regression/same_unnamed_kernels.cpp | Switch buffer accessor mode and accessor type template parameter to sycl::access_mode. |
| sycl/test-e2e/Regression/private_array_init_test.cpp | Switch buffer accessor mode to s::access_mode. |
| sycl/test-e2e/Regression/multiple-targets.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Regression/local-arg-align.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/kernel_bundle_ignore_sycl_external.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/implicit_kernel_bundle_image_filtering.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/group.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Regression/fp16-with-unnamed-lambda.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/commandlist/Inputs/FindPrimesSYCL.cpp | Switch constexpr access mode values to sycl::access_mode. |
| sycl/test-e2e/Regression/2020-spec-constants-debug-info.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Reduction/reduction_usm.cpp | Switch input accessor mode to access_mode and update output accessor mode spelling. |
| sycl/test-e2e/Reduction/reduction_range_1d_reducer_skip.cpp | Switch constexpr access mode to access_mode. |
| sycl/test-e2e/Reduction/reduction_nd_conditional.cpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/Reduction/reduction_big_data.cpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/KernelParams/struct_kernel_param.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/KernelParams/array-kernel-param-nested-run.cpp | Switch accessor template args and buffer accessor modes to access_mode. |
| sycl/test-e2e/KernelCompiler/opencl_cache.cpp | Switch set_arg accessors to sycl::access_mode. |
| sycl/test-e2e/IntermediateLib/Inputs/incrementing_lib.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_plus_mod.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_mul.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_if.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_float_add.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_8_no_input_int.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_16_no_input_int.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/HostInteropTask/interop-task.cpp | Switch template accessor modes from mode::* to sycl::access_mode::*. |
| sycl/test-e2e/HostInteropTask/host-task.cpp | Switch template accessor modes from mode::* to sycl::access_mode::*. |
| sycl/test-e2e/HostInteropTask/host-task-dependency3.cpp | Switch template accessor modes from mode::* to sycl::access_mode::*. |
| sycl/test-e2e/GroupLocalMemory/no_early_opt.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/GroupAlgorithm/leader.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Functor/kernel_functor.cpp | Switch constexpr access mode value to sycl::access_mode. |
| sycl/test-e2e/FreeFunctionKernels/enum_parameter.cpp | Switch accessor type aliases and function params from access::mode to access_mode. |
| sycl/test-e2e/Experimental/reusable_events/queue_returned_events.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/in_order_queue_signal.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/event_as_dependency.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_work_group_size.cpp | Switch accessor template args and buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_num_work_groups.cpp | Switch accessor template args and buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/DotProduct/dot_product_vec_test.cpp | Switch multiple buffer accessor modes to access_mode. |
| sycl/test-e2e/DeviceLib/std_complex_math_test.cpp | Switch constexpr access mode values to s::access_mode. |
| sycl/test-e2e/DeviceLib/math_windows_test.cpp | Switch constexpr access mode values to s::access_mode. |
| sycl/test-e2e/DeviceLib/math_override_test.cpp | Switch constexpr access mode values to s::access_mode. |
| sycl/test-e2e/DeviceLib/ITTAnnotations/barrier.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/DeviceLib/imf/simd_emulate_test.cpp | Switch constexpr access mode values to s::access_mode. |
| sycl/test-e2e/DeviceLib/complex_utils.hpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/c99_complex_math_test.cpp | Switch constexpr access mode value to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/vector_math.cpp | Switch buffer accessor modes to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/vector_common.cpp | Switch buffer accessor modes to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/scalar_math.cpp | Switch buffer accessor modes to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/scalar_common.cpp | Switch buffer accessor mode to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/ext_native_math_common.hpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_static.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_arrow.hpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/DeprecatedFeatures/set_arg_interop.cpp | Switch accessor modes and accessor template args to access_mode. |
| sycl/test-e2e/Config/env_vars.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/vector/byte.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/sycl-namespace.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/span.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/parallel_for_user_types.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Basic/nested_queue_submit.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/multi_ptr_null_relational_operators.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/linear-sub_group.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/kernel_bundle/kernel_bundle_api_hip.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/image/srgba-read.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/image/image_sample.cpp | Switch image accessor mode and result accessor mode to s::access_mode. |
| sycl/test-e2e/Basic/image/image_array.cpp | Switch constexpr access mode values to sycl::access_mode. |
| sycl/test-e2e/Basic/image/image_accessor_readsampler.cpp | Switch image accessor mode and result accessor mode to s::access_mode. |
| sycl/test-e2e/Basic/host-task-dependency.cpp | Switch host_accessor/accessor template args to S::access_mode. |
| sycl/test-e2e/Basic/handler/handler_copy_with_offset.cpp | Switch constexpr access mode values to access_mode. |
| sycl/test-e2e/Basic/group_async_copy_legacy.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/free_function_queries/free_function_queries_sub_group.cpp | Switch accessor template args and buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Basic/fill_accessor.cpp | Switch accessor template args to sycl::access_mode. |
| sycl/test-e2e/Basic/event.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/char_builtins.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/buffer/reinterpret.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Basic/buffer/buffer_full_copy.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Basic/bit_cast/bit_cast.cpp | Switch constexpr access mode value to sycl::access_mode. |
| sycl/test-e2e/Basic/access_to_subset.cpp | Switch accessor template args to access_mode. |
| sycl/test-e2e/AtomicRef/store.h | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/max.h | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/AtomicRef/compare_exchange.h | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/AtomicRef/assignment.h | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Assert/assert_in_simultaneously_multiple_tus.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Assert/assert_in_kernels.hpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/AddressCast/khr_static_addrspace_cast.cpp | Switch buffer accessor modes to sycl::access_mode. |
Suppressed comments (2)
sycl/test-e2e/AtomicRef/compare_exchange.h:95
- Same issue as above:
access_mode::discard_writewill become deprecated and-Werrorwill fail the test build. Preferwrite_only+no_init.
auto exc =
compare_exchange_buf.template get_access<access_mode::read_write>(
cgh);
auto out =
output_buf.template get_access<access_mode::discard_write>(cgh);
cgh.parallel_for(range<1>(N), [=](item<1> it) {
sycl/test-e2e/AtomicRef/max.h:89
- Same issue as above:
access_mode::discard_writewill become deprecated and-Werrorwill fail the test build. Preferwrite_only+no_init.
auto val = val_buf.template get_access<access_mode::read_write>(cgh);
auto out =
output_buf.template get_access<access_mode::discard_write>(cgh);
cgh.parallel_for(range<1>(N), [=](item<1> it) {
sarnex
approved these changes
Jul 31, 2026
Contributor
Author
|
failure: #22284 |
cperkinsintel
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803
1st - #22842
2nd - #22843