[SYCL] Make ipc::event::put() optional - #22845
Open
againull wants to merge 2 commits into
Open
Conversation
Align the ipc::event put() wording with ipc::memory and ipc::physical_memory: the resources associated with the handle are automatically deallocated when the event object is destroyed, so calling put() is not strictly necessary. Remove the note requiring a put() call for each handle received from get(). Assisted-By: Claude
`put()` is already specified as optional for ipc::memory and ipc::physical_memory, so align specification and implementation of `ipc::event` to have same behaviour. Cache the exported IPC event handle on event_impl the first time ipc::event::get() is called, and release it in ~event_impl via urIPCPutEventHandleExp. This makes calling ipc::event::put() optional. ipc::event::put() becomes a no-op. Assisted-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
put()is already specified as optional for ipc::memory and ipc::physical_memory, so align specification and implementation ofipc::eventto have same behaviour.Cache the exported IPC event handle on event_impl the first time
ipc::event::get()is called, and release it in~event_implviaurIPCPutEventHandleExp. This makes callingipc::event::put()optional.ipc::event::put()becomes a no-op.Assisted-By: Claude