[sycl-jit] Fix missing build rule for resource-shard-*.cpp with Makefiles generator - #22848
Open
wenju-he wants to merge 1 commit into
Open
[sycl-jit] Fix missing build rule for resource-shard-*.cpp with Makefiles generator#22848wenju-he wants to merge 1 commit into
wenju-he wants to merge 1 commit into
Conversation
…iles generator The generated resource-shard-N.cpp files were declared as BYPRODUCTS of the generate.py custom command rather than OUTPUT. CMake's Unix/ NMake Makefiles generators don't emit build rules for BYPRODUCTS (unlike Ninja, which tracks byproducts as first-class outputs), so a fresh build fails with "No rule to make target 'resource-shard-0.cpp'". Moving the shard files into OUTPUT gives Make a proper rule to produce them alongside resource.cpp. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated resource-shard-N.cpp files were declared as BYPRODUCTS of the generate.py custom command rather than OUTPUT. CMake's Unix/ NMake Makefiles generators don't emit build rules for BYPRODUCTS (unlike Ninja, which tracks byproducts as first-class outputs), so a fresh build fails with "No rule to make target
'resource-shard-0.cpp'". Moving the shard files into OUTPUT gives Make a proper rule to produce them alongside resource.cpp.