[PB-6678] feature/Improve Photos timeline - #556
Open
CandelR wants to merge 3 commits into
Open
Conversation
…g-to-upload-status [PB-6660] bugfix/recently uploaded photos are incorrectly shown as ‘pending upload’
Base automatically changed from
bugfix/PB-6660-incorrect-waiting-to-upload-status
to
bugfix/PB-6653-incorrect-backup-status
July 30, 2026 13:56
…, and replaced deprecated react-native-fast-image with expo-image
CandelR
force-pushed
the
feature/improve-Photos-assets-renders-and-uri-load
branch
from
July 30, 2026 13:56
e64156b to
91eb5a9
Compare
|
CandelR
changed the base branch from
bugfix/PB-6653-incorrect-backup-status
to
feature/PB-6068-photos-backup
July 30, 2026 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves Photos timeline responsiveness during background backups, and replaces the deprecated react-native-fast-image with expo-image
Summary
useCloudAssets,useLocalAssetsSyncStatus: skipsetStatewhen the cloud/local asset data is unchanged (lodash.isEqualinside the functional updater), instead of unconditionally replacing it on every sync tick.PhotosScreen/index.tsx:handlePhotoPress/handlePhotoLongPressno longer depend on the fullselectionobject orallItemsby reference, both were recreated on every screen re-render, which defeatedPhotoItem's memo comparator and forced every visible cell to re-render on every background sync event.PhotoItem.tsx: migrated fromreact-nativeImagetoexpo-imagewithrecyclingKey, anduseRecyclingStatefor the loading flag, for more reliable behavior when FlashList recycles a cell onto a different asset.UserProfilePicture,DriveGridModeItem: migrated fromreact-native-fast-imagetoexpo-image.package.json:react-native-fast-imageremoved,expo-imageadded.