[PB-6699] Remove old key fields from UserSettings - #2033
Open
TamaraFinogina wants to merge 18 commits into
Open
Conversation
Deploying drive-web with
|
| Latest commit: |
19da5a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://561f5310.drive-web.pages.dev |
| Branch Preview URL: | https://remove-old-key-fields.drive-web.pages.dev |
TamaraFinogina
marked this pull request as ready for review
July 28, 2026 16:28
TamaraFinogina
requested review from
a team,
CandelR and
larryrider
as code owners
July 28, 2026 16:28
larryrider
previously approved these changes
Jul 29, 2026
larryrider
previously approved these changes
Jul 29, 2026
sg-gs
requested changes
Jul 29, 2026
sg-gs
reviewed
Jul 30, 2026
| return { | ||
| xUser: { | ||
| ...user, | ||
| bucket: '', |
Contributor
Author
There was a problem hiding this comment.
Because the endpoint is not returning any value for the bucket field, and the UserSettings type needs it. Before, it was masked due to a type cast to UserSettings, but TODO is still present:
// TODO: need to update user type of register to include bucket field
Member
|
Nice cleanup here @TamaraFinogina |
sg-gs
previously approved these changes
Jul 31, 2026
TamaraFinogina
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the amount of data in UserSettings by removing old fields (
privateKey,publicKey, andrevocationKeyoutside of thekeysstructure). Will help once we start encrypting UserSettings.P.S. Most changes are from deleted tests that were for testing that the old key structure works (without the keys field but with privateKey, publicKey, and revocationKey outside of the keys structure)
Related Issues
PB-6505
Related Pull Requests
Checklist
Testing Process
Check that login, signup, key backup and password change are working.
Additional Notes
We switched to keys in UserSettings over a year ago. There should be no users with an ongoing session without a Kyber key or keys field.