[PB-6531]feat/skip item option in name collision - #2039
Open
jaaaaavier wants to merge 1 commit into
Open
Conversation
Deploying drive-web with
|
| Latest commit: |
4917eaf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e4d78d49.drive-web.pages.dev |
| Branch Preview URL: | https://feat-skip-item-option-in-nam.drive-web.pages.dev |
|
jaaaaavier
marked this pull request as ready for review
July 13, 2026 14:03
CandelR
reviewed
Jul 20, 2026
| "title": "Umbenennen", | ||
| "label": "Name" | ||
| }, | ||
| "renameModal": { |
Collaborator
There was a problem hiding this comment.
nit: why teh change of the key?
| "description": "{{itemName}} ya existe en esta carpeta. ¿Deseas reemplazarlo o mantener los dos?", | ||
| "multipleDescription": "Más de un elemento existe en esta localización. Deseas reemplazarlos o mantenerlos?", | ||
| "selectOption": "Selecciona una opción", | ||
| "description": "{{itemName}} ya existe en esta ubicación. ¿Deseas reemplazarlo por el que estás moviendo?", |
Collaborator
There was a problem hiding this comment.
it is like always gonna move all the items and it is not the only action. The modal also is used for uploading
Comment on lines
+152
to
+159
| {remainingItemsCount > 1 && ( | ||
| <div className="flex items-center"> | ||
| <Checkbox checked={applyToAll} onClick={() => setApplyToAll((prev) => !prev)} /> | ||
| <p className="ml-2 select-none text-base font-medium text-gray-80"> | ||
| {translate('modals.alreadyExistsModal.applyToAll')} | ||
| </p> | ||
| </div> | ||
| )} |
Collaborator
There was a problem hiding this comment.
to keep element consistency maybe we should do that pressint the text also select/unselect the checkbox
| case 'upload' + 'replace': | ||
| await replaceAndUploadSingleItem(itemToUpload as IRoot | File, itemToReplace, group.destinationUuid); | ||
| break; | ||
| case 'upload' + 'skip': |
Collaborator
There was a problem hiding this comment.
move + skip option should exists or is only for upload option?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we want to give the user the option, when uploading a file that already exists, to skip uploading that file and choose on a file-by-file basis what to do (move, keep or skip). To achieve this, we have implemented the new dialogue box design and modified the existing functions that handled these actions so that they operate on a per-file basis rather than on groups of files; in this way, we ensure that the user can effectively choose what to do with each file individually.
Related Issues
Related Pull Requests
Checklist
Testing Process
Tested uploading existing files, then, verified that all functions work as expected
Additional Notes