feat:(PB-6297) download and preview individual items in public shared folder by victor-ferro · Pull Request #2054 · internxt/drive-web

victor-ferro · 2026-07-17T15:34:29Z

Description

Third and final part of PB-6297, stacked on #2053. The public shared folder preview becomes actionable: items can now be downloaded individually (or in multi-selection) and files can be previewed in the viewer, all without authentication.

Per-item download

downloadPublicSharedItems (new in share.service.ts): generalizes the existing root-folder download to any selection — a single file downloads directly (stream → blob → save), a single folder zips through the public iterators, and a mixed selection packs everything into one zip. downloadPublicSharedFolder is now a thin wrapper over it (same behavior as before for the main Download button).
Context menu (right-click / three-dots) with Download on any selection, and a beforeunload warning while a download is in flight.

File preview

Double-click (or Preview in the menu) opens the plain FileViewer with the decrypted blob, download progress, and the same gates as ShareFileView: previewable type and size limit — otherwise the viewer opens with its fallback without fetching the blob.
TopBarActions gets a dedicated share-view variant: Download + Report (reusing handleReportShare, now exported from ReportButton). This also removes a dead branch: the old copy-link button was unreachable in share views. Phosphor deprecated icon names updated (DotsThreeIcon, WarningCircleIcon).

Cleanups (code created earlier in this stack)

usePublicSharedFolderContent: fetchFolders/fetchFiles merged into a single fetchLevelItems(type) — same phase machine (folders per level, then files), ~20 duplicated lines removed. Test assertions updated accordingly.
useWarnBeforeUnload (new hook): replaces the three identical handleLeavePage + beforeunload effect copies in ShareFolderView, ShareFileView and the new preview; also fixes the effect depending only on progress instead of the full active condition.
isTypeAllowed now reuses getIsTypeAllowedAndFileExtensionGroupValues from fileViewerUtils (also fixes uppercase extensions being rejected).
ShareLayout: user menu dropdown gets z-50 so it stays above the new preview content.

Related Issues

Relates to PB-6297.

Related Pull Requests

Stacked on feat:(PB-6297) show image thumbnails in public shared folder preview #2053 (PB-6297-thumbnails), which is stacked on feat:(PB-6297) preview public shared folder contents #2052 — merge in order: feat:(PB-6297) preview public shared folder contents #2052 → feat:(PB-6297) show image thumbnails in public shared folder preview #2053 → this one.

Checklist

Changes have been tested locally.
Unit tests have been written or updated as necessary.
The code adheres to the repository's coding standards.
Relevant documentation has been added or updated.
No new warnings or errors have been introduced.
SonarCloud issues have been reviewed and addressed.
QA Passed

Testing Process

Unit tests: yarn vitest run src/app/share/services/share.service.test.ts — three new cases for downloadPublicSharedItems (single file with share credentials/key and plain name, single folder zipped through the public iterators, mixed selection packed into one zip closed at the end). Hook tests updated for the unified fetch.
yarn typecheck and yarn lint clean; full unit suite run by the pre-commit hook.
Manual: on a public shared folder link — downloaded a single file, a folder, and a mixed multi-selection (zip); previewed images/PDFs via double-click and the context menu; verified non-previewable and oversized files open the viewer fallback without downloading; downloaded from inside the viewer; checked the leave-page warning appears only while downloading; Report button in the viewer opens the report email.

… folder

cloudflare-workers-and-pages · 2026-07-17T16:02:36Z

Deploying drive-web with Cloudflare Pages

Latest commit:	`6f83655`
Status:	✅ Deploy successful!
Preview URL:	https://2427487e.drive-web.pages.dev
Branch Preview URL:	https://pb-6297-preview-download.drive-web.pages.dev

View logs

…terators New-code coverage was failing the SonarCloud quality gate (75% vs 80% required). Adds tests for the untested useWarnBeforeUnload hook and for the previously uncovered lines in share.service.ts: the folders/files iterator factories passed to downloadFolderAsZip, and the happy/error paths of downloadPublicSharedFolder.

# Conflicts: # src/views/PublicShared/hooks/usePublicSharedFolderContent.ts

# Conflicts: # src/views/PublicShared/components/PublicSharedFolderContent.tsx # src/views/PublicShared/components/PublicSharedItemList.tsx # src/views/PublicShared/hooks/usePublicSharedFolderContent.ts

CandelR · 2026-07-29T07:15:25Z

+    downloadFile({
+      bucketId: (shareItem as unknown as DriveFileData).bucket,
+      fileId: (shareItem as unknown as DriveFileData).fileId,
+      creds: shareCredentials,
+      key: publicShareKey,
+      options: {
+        notifyProgress: (totalBytes, downloadedBytes) => {
+          setPreviewProgress(downloadedBytes / totalBytes);
+        },
+      },
+    })
+      .then((fileStream) => binaryStreamToBlob(fileStream, shareItem.type || ''))
+      .then((fileBlob) => {
+        setPreviewBlob(fileBlob);
+      })


need to verify that the downloaded item is the same as actually opened, this can cause that user press one item, close instantalnealy, open another, and flash the preview of first item until the second is downloaded

CandelR · 2026-07-29T07:17:21Z

+    if (!isTypeAllowed(shareItem) || !isFileSizePreviewable(Number(shareItem.size))) return;
+
+    downloadFile({
+      bucketId: (shareItem as unknown as DriveFileData).bucket,


avoid as unknown cast outside of tests

Done! It's been detected that the AdvancedSharedItem type doesn't have fileId because the SharedFiles imported from the SDK has a field called 'fileiId' but doesn't have 'fileId'

CandelR · 2026-07-29T07:18:15Z

+  const downloadItems = (itemsToDownload: AdvancedSharedItem[]) => {
+    if (isDownloading || itemsToDownload.length === 0 || !shareCredentials) return;
+
+    setIsDownloading(true);
+
+    downloadPublicSharedItems({
+      items: itemsToDownload,
+      credentials: shareCredentials,
+      key: publicShareKey,
+      code,
+      resourcesToken: nextLevelToken,
+    })
+      .catch((err) => {
+        errorService.reportError(err);
+        notificationsService.show({ text: errorService.castError(err).message, type: ToastType.Error });
+      })
+      .finally(() => {
+        setIsDownloading(false);
+      });
+  };


I would extract all the download logic added for previewing into a hook

CandelR · 2026-07-29T07:38:34Z

+  return confirmationMessage; // WebKit, Chrome <34
+};
+
+const useWarnBeforeUnload = (isActive: boolean): void => {


this hook already exists: useBeforeUnload.ts

I hadn't seen it. The functionality I put into the hook was also being used in other places, and I thought there wasn't already an existing hook for this. My bad!!
Done!

CandelR · 2026-07-29T07:41:33Z

+  return `${item.plainName ?? item.name}${extension}`;
+};
+
+export async function downloadPublicSharedItems({


Doesn't the DownloadManager cover this?

True, it can be done, but it touches several things in the main download flow. Because for public downloads we'd run into some blockers:

generateTasksForItem calls localStorageService.getUser() and throws 'User not found' before even looking at downloadCredentials, so anonymous visitors crash right away.

Progress is reported through tasksService, and TaskLogger is only mounted in HeaderAndSidenavLayout — an anonymous user would get a download with zero feedback, and the preview UI here doesn't read from tasks.

Single files go through the download worker, and postMessage turns the { bucketKey: Buffer } key (new sharing version) into a plain Uint8Array, which the network crypto won't accept without re-hydrating it in the worker.

If you want me to get started on it, I will. But maybe it might be work for a separate ticket

Okay, so we’ll have to create a task to decouple DownloadManager from everything that isn’t handle ‘download', because, as we have seen, it does not allow us to reuse it 😞

Moves download and preview state out of PublicSharedFolderContent into usePublicSharedDownload, discarding stale preview downloads when the preview is closed or replaced, and removes 'as unknown as' casts by typing fileId on AdvancedSharedItem and narrowing helper signatures.

…elds

CandelR · 2026-07-29T13:49:11Z

@@ -0,0 +1,102 @@
+/**
+ * @jest-environment jsdom
+ */


we don't use jest, this tag is not necessary

CandelR · 2026-07-29T13:49:20Z

@@ -0,0 +1,267 @@
+/**
+ * @jest-environment jsdom
+ */


same here, we don't use jest

sonarqubecloud · 2026-07-31T10:15:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

victor-ferro requested review from CandelR and larryrider as code owners July 17, 2026 15:34

feat:(PB-6297) download and preview individual items in public shared…

87247c8

… folder

victor-ferro force-pushed the PB-6297-preview-download branch from 9c0ef9b to 87247c8 Compare July 17, 2026 16:02

victor-ferro self-assigned this Jul 24, 2026

victor-ferro added 3 commits July 27, 2026 19:13

Merge branch 'PB-6297-thumbnails' into PB-6297-preview-download

190ba29

# Conflicts: # src/views/PublicShared/hooks/usePublicSharedFolderContent.ts

Merge branch 'PB-6297-thumbnails' into PB-6297-preview-download

f8c266a

# Conflicts: # src/views/PublicShared/components/PublicSharedFolderContent.tsx # src/views/PublicShared/components/PublicSharedItemList.tsx # src/views/PublicShared/hooks/usePublicSharedFolderContent.ts

fix:(PB-6297) add explicit button type to file viewer top bar actions

4a833de

CandelR reviewed Jul 29, 2026

View reviewed changes

victor-ferro added 4 commits July 29, 2026 10:45

refactor:(PB-6297) narrow downloadFolderAsZip folder param to used fi…

c5bc944

…elds

refactor:(PB-6297) map shared item to preview file instead of casting

c1c4298

refactor:(PB-6297) reuse useBeforeUnload instead of duplicated hook

cfe7586

victor-ferro requested a review from CandelR July 29, 2026 10:11

CandelR reviewed Jul 29, 2026

View reviewed changes

refactor:(PB-6297) drop unused jest-environment tags from vitest tests

69dd686

CandelR approved these changes Jul 29, 2026

View reviewed changes

victor-ferro added 2 commits July 31, 2026 12:09

fix:(PB-6297) fit public shared folder view to mobile viewports

2c98f44

fix:(PB-6297) fit file viewer previews to portrait viewports

6f83655

Uh oh!

Conversation

victor-ferro commented Jul 17, 2026

Description

Related Issues

Related Pull Requests

Checklist

Testing Process

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying drive-web with Cloudflare Pages

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 31, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cloudflare-workers-and-pages Bot commented Jul 17, 2026 •

edited

Loading