[PB-6258] feat: add size filter to global search - #2073
Open
victor-ferro wants to merge 10 commits into
Open
Conversation
Deploying drive-web with
|
| Latest commit: |
5bd958b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a5621bc.drive-web.pages.dev |
| Branch Preview URL: | https://pb-6258-search-size-filter.drive-web.pages.dev |
…s the empty state
…rch shows the empty state" This reverts commit c420428.
…lter # Conflicts: # src/views/Home/components/SearchDateFilter.tsx
…ed SearchFilterRow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Part 4/4 of the PB-6258 stack. Adds the "Size" pill with single-choice presets (Less than 5 MB / 100 MB / 1 GB, More than 1 GB) and a Custom range mode with Bigger than / Smaller than numeric inputs, each with its own unit selector (B–TB). Changes that would invert the range in bytes are rejected. Extracts the shared
SearchFilterRadioList(adopted by the date filter too) and closes filter panels on Enter. Includes unit tests for the size helpers and i18n for the 8 locales.Blocked by internxt/sdk#429 (see base PR #2069).
Related Issues
Relates to PB-6258 (JIRA).
Related Pull Requests
Checklist
Testing Process
Manual browser testing: each preset issues the expected
minSize/maxSizebyte params; custom bounds convert with their own unit; inverted ranges are ignored; Enter in the custom inputs closes the panel without resetting the selection; combined with type and date filters in the same query. Unit tests coversizePresetToRangeandchangeCustomSize.