Skip to content

[PB-6258] feat: add size filter to global search - #2073

Open
victor-ferro wants to merge 10 commits into
PB-6258-search-date-filterfrom
PB-6258-search-size-filter
Open

[PB-6258] feat: add size filter to global search#2073
victor-ferro wants to merge 10 commits into
PB-6258-search-date-filterfrom
PB-6258-search-size-filter

Conversation

@victor-ferro

Copy link
Copy Markdown

Description

Part 4/4 of the PB-6258 stack. Adds the "Size" pill with single-choice presets (Less than 5 MB / 100 MB / 1 GB, More than 1 GB) and a Custom range mode with Bigger than / Smaller than numeric inputs, each with its own unit selector (B–TB). Changes that would invert the range in bytes are rejected. Extracts the shared SearchFilterRadioList (adopted by the date filter too) and closes filter panels on Enter. Includes unit tests for the size helpers and i18n for the 8 locales.

Blocked by internxt/sdk#429 (see base PR #2069).

Related Issues

Relates to PB-6258 (JIRA).

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Manual browser testing: each preset issues the expected minSize/maxSize byte params; custom bounds convert with their own unit; inverted ranges are ignored; Enter in the custom inputs closes the panel without resetting the selection; combined with type and date filters in the same query. Unit tests cover sizePresetToRange and changeCustomSize.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5bd958b
Status: ✅  Deploy successful!
Preview URL: https://0a5621bc.drive-web.pages.dev
Branch Preview URL: https://pb-6258-search-size-filter.drive-web.pages.dev

View logs

@victor-ferro
victor-ferro marked this pull request as ready for review July 29, 2026 14:42
@victor-ferro victor-ferro self-assigned this Jul 31, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant