[_] bugfix/url validation redirect - #2074
Open
CandelR wants to merge 6 commits into
Open
Conversation
Deploying drive-web with
|
| Latest commit: |
486b8f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae385f9c.drive-web.pages.dev |
| Branch Preview URL: | https://bugfix-url-validation-redire.drive-web.pages.dev |
larryrider
requested changes
Jul 31, 2026
| }) | ||
| ) { | ||
| baseURL = decoded; | ||
| } |
Contributor
There was a problem hiding this comment.
if there is a redirectUri but it is not valid (malicius url not pointing to internxt or localhost) then we redirect to the baseURL. Maybe it would be better to just dont redirect at all
Collaborator
Author
There was a problem hiding this comment.
That’s a good point, perhaps it would be better to display a ‘invalid URL’ notification and don't redirect. What do you think?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return; | ||
| } | ||
|
|
||
| globalThis.location.href = universalLinkAuthUrl; |
| return; | ||
| } | ||
|
|
||
| globalThis.location.href = universalLinkAuthUrl; |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a redirect vulnerability in the login/signup flow.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes