Skip to content

[MKT_949]:feature/ add turnstileToken for checkout payloads - #432

Open
jaaaaavier wants to merge 2 commits into
masterfrom
feature/add-turnstile-token
Open

[MKT_949]:feature/ add turnstileToken for checkout payloads#432
jaaaaavier wants to merge 2 commits into
masterfrom
feature/add-turnstile-token

Conversation

@jaaaaavier

Copy link
Copy Markdown
Contributor

Adds an optional turnstileToken field to the three checkout payloads so the checkout client can forward a Cloudflare Turnstile token to the payments API.

@jaaaaavier jaaaaavier self-assigned this Jul 24, 2026
@jaaaaavier jaaaaavier added the enhancement New feature or request label Jul 24, 2026
@jaaaaavier
jaaaaavier requested a review from xabg2 July 27, 2026 12:32

@xabg2 xabg2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If captcha token is the fallback one and turnstile is the primary, should the captcha token optional and the other one the required? 🤔

@jaaaaavier

jaaaaavier commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

If captcha token is the fallback one and turnstile is the primary, should the captcha token optional and the other one the required? 🤔

It makes sense, and that’s how I saw it, but I considered the scenario where perhaps these interfaces are used on sites I dont know, and I wouldn’t want to break anything, then I also considered the scenario where Cloudflare goes down, for example (just as Google might), and I thought it’s better to have the fallback as the required and this one as optional. Bearing in mind what I said earlier, I don’t know if, for example, any other object-storage repo use interfaces.

@jaaaaavier jaaaaavier changed the title [MKT_923]:feature/ add turnstileToken for checkout payloads [MKT_949]:feature/ add turnstileToken for checkout payloads Jul 28, 2026
@jaaaaavier
jaaaaavier requested a review from xabg2 July 29, 2026 08:26
@xabg2

xabg2 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

If captcha token is the fallback one and turnstile is the primary, should the captcha token optional and the other one the required? 🤔

It makes sense, and that’s how I saw it, but I considered the scenario where perhaps these interfaces are used on sites I dont know, and I wouldn’t want to break anything, then I also considered the scenario where Cloudflare goes down, for example (just as Google might), and I thought it’s better to have the fallback as the required and this one as optional. Bearing in mind what I said earlier, I don’t know if, for example, any other object-storage repo use interfaces.

You can check if the interface is used in other places. The thing here is that, if we are changing from captcha to turnstile, it should be applied everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants