[Raft] Initialization and configuration of consensus#1473
Merged
Conversation
MariemBaccari
changed the title
This was referenced May 20, 2026
MariemBaccari
force-pushed
the
add_consensus_logic_1
branch
2 times, most recently
from
034d8f2 to
01747d1
Compare
the-glu
reviewed
May 27, 2026
MariemBaccari
changed the title
MariemBaccari
force-pushed
the
add_consensus_logic_1
branch
3 times, most recently
from
9857b0a to
a29eb0b
Compare
barroco
reviewed
Jun 15, 2026
MariemBaccari
force-pushed
the
add_consensus_logic_1
branch
2 times, most recently
from
6e87fff to
d190965
Compare
barroco
reviewed
Jun 15, 2026
barroco
left a comment
barroco
left a comment
Contributor
There was a problem hiding this comment.
@MariemBaccari thanks a lot for this PR. You will find additional comments and suggestions. Don't hesitate if you have any questions.
MariemBaccari
force-pushed
the
add_consensus_logic_1
branch
2 times, most recently
from
223f155 to
94cf0aa
Compare
MariemBaccari
force-pushed
the
add_consensus_logic_1
branch
2 times, most recently
from
1eea1a9 to
cb29be1
Compare
MariemBaccari
force-pushed
the
add_consensus_logic_1
branch
from
cb29be1 to
1d8b3f0
Compare
barroco
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the chain #1470 -> #1473 -> #1474 to address the issue #1463.
To keep it readable, it only contains part of the consensus logic with some stub functions to be implemented in a follow-up PR.
It defines the default configuration for Raft with similar values as etcd (to be tuned later).
It also completes the initialization of consensus and the
handleReady()goroutine.