[scd] Add hash lock option #1520
Open
the-glu wants to merge 1 commit into
Open
Conversation
the-glu
commented
Jun 10, 2026
This was referenced Jun 10, 2026
Member
|
I think we should check performance under conditions at least somewhat similar to real operations, which I think means at least multiple nodes, probably multiple instances, and latency between nodes. I first measured v0.22.0 with: With 10 users, I got:
I then measured with this branch:
Just to make sure my retag worked: I see some latency improvement versus v0.22.0 and a tiny throughput improvement, so looks reasonable to me. I will leave final approval to @barroco with his greater practical experience with database operations than me. |
6a5d9fe to
c635b72
Compare
barroco
reviewed
Jun 17, 2026
barroco
left a comment
Contributor
There was a problem hiding this comment.
Still reviewing the results.
Contributor
|
Thanks for the update - Will run some tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR follow #1518 as it increase performance of that PR.
Add a new option to lock cells using an hash, as an intermediate between the global lock option and the subscriptions lock.
Using
FlightsInSubstest, with 8 clusters, on a single-local CRDB node we can see an improvement others lock methods.(Don't include option in terraform/helm/tanka yet)