[raft] Change transact signature#1574
Closed
MariemBaccari wants to merge 1 commit into
Closed
Conversation
MariemBaccari
force-pushed
the
change_transact_signature
branch
from
70a8ca0 to
7d3c841
Compare
barroco
reviewed
Jun 26, 2026
MariemBaccari
force-pushed
the
change_transact_signature
branch
from
7d3c841 to
893034b
Compare
barroco
reviewed
Jun 26, 2026
| @@ -16,7 +22,9 @@ type Store[R any] interface { | |||
| Interact(context.Context) (R, error) | |||
| // Attempt to apply the operations in f to the R Repo it is supplied. All operations performed | |||
| // on the R Repo by f will be applied or rejected atomically. | |||
Contributor
There was a problem hiding this comment.
Please update this description to scope the usage for sqlstore
Contributor
Author
There was a problem hiding this comment.
I updated it to ignore the specific store details. What do you think ?
MariemBaccari
force-pushed
the
change_transact_signature
branch
from
893034b to
8321be0
Compare
barroco
added
the
dss-raft
Contributor
Author
|
Replaced by #1577 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
Transactsignature to supportRaftstoreparameters.