You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Doesn't yet have a spec/features, but needs one. I am having trouble
figuring out where to fit it in to the existing spec structure how, can
you advise @inukshuk on some hints as to what a good spec for this would look like? (I hope not a cucumber features, cause cucumber drives me crazy)
Uh, it looks like contrary to docs CiteProc::CitationItem was not the only legal thing to pass into Renderer#render. Something... else was being passed in in tests, which my code turns into a CiteProc::CitationItem and ruins it.
it looks like maybe everything is maybe some kind of CiteProc::Attributes, of which CiteProc::CitationItem is one example. Perhaps the doc @param should note that, not sure.
Do note that it looks like Renderer#renderis used "under the hood" in things, changes we make there, if they effect performance, may effect other things than top-level manual use of Renderer#render. But I'm not too worried about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't yet have a spec/features, but needs one. I am having trouble
figuring out where to fit it in to the existing spec structure how, can
you advise @inukshuk on some hints as to what a good spec for this would look like? (I hope not a cucumber features, cause cucumber drives me crazy)
ref #55
ref #53