Skip to content

allow Renderer#render to take a hash of CSL input data#56

Open
jrochkind wants to merge 1 commit into
inukshuk:masterfrom
jrochkind:renderer_render_takes_hash
Open

allow Renderer#render to take a hash of CSL input data#56
jrochkind wants to merge 1 commit into
inukshuk:masterfrom
jrochkind:renderer_render_takes_hash

Conversation

@jrochkind

Copy link
Copy Markdown
Contributor

Doesn't yet have a spec/features, but needs one. I am having trouble
figuring out where to fit it in to the existing spec structure how, can
you advise @inukshuk on some hints as to what a good spec for this would look like? (I hope not a cucumber features, cause cucumber drives me crazy)

ref #55
ref #53

@jrochkind

Copy link
Copy Markdown
Contributor Author

oops, failing travis for real. I'll look into it.

@jrochkind

Copy link
Copy Markdown
Contributor Author

Uh, it looks like contrary to docs CiteProc::CitationItem was not the only legal thing to pass into Renderer#render. Something... else was being passed in in tests, which my code turns into a CiteProc::CitationItem and ruins it.

Trying to debug, but appreciate any ideas.

@jrochkind

Copy link
Copy Markdown
Contributor Author

it looks like maybe everything is maybe some kind of CiteProc::Attributes, of which CiteProc::CitationItem is one example. Perhaps the doc @param should note that, not sure.

Do note that it looks like Renderer#render is used "under the hood" in things, changes we make there, if they effect performance, may effect other things than top-level manual use of Renderer#render. But I'm not too worried about it.

@jrochkind jrochkind force-pushed the renderer_render_takes_hash branch from fffa632 to 2012948 Compare March 7, 2018 22:23
@krzysiek1507

Copy link
Copy Markdown

Hi! Any chance to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants