SRv6 next hops for global BGP routes on FRR#3369
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds FRR support for SRv6 next-hops on global (non-VPN) BGP routes and updates SRv6 integration tests/docs accordingly.
Changes:
- Enable
features.srv6.bgpfor FRR devices and extend the FRR SRv6 templates to configure BGP SRv6 encapsulation/behavior for global unicast routes. - Add FRR-specific SRv6 bootstrapping (VRF device creation) when SRv6+BGP is used.
- Clean up SRv6 integration tests (standardized waits, shared warnings defaults) and refresh SRv6 module documentation to reflect global BGP SRv6 transport support.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/srv6/11-isis-ipv6-bgp.yml | Standardizes validation waits and pulls in shared warnings defaults; adjusts SRv6 loopback allocation behavior. |
| tests/integration/srv6/01-isis-ipv4-bgp.yml | Same integration test cleanup (wait constants, warnings defaults) plus minor SRv6/BGP-related tweaks. |
| netsim/devices/frr.yml | Marks FRR as supporting srv6.bgp. |
| netsim/ansible/templates/srv6/frr.j2 | Adds SRv6-related VRF device creation and includes SRv6 BGP template when srv6.bgp is enabled. |
| netsim/ansible/templates/srv6/frr.bgp.j2 | Adds global BGP SRv6 neighbor/address-family configuration (including encapsulation-srv6). |
| docs/module/srv6.md | Updates documented supported features/platform support and clarifies srv6.bgp semantics for global routes. |
jbemmel
reviewed
May 10, 2026
| prefix: 32 | ||
|
|
||
| srv6.allocate_loopback: True # Override the ipv6 loopback address and allocate one from the per-node locator range | ||
| srv6.allocate_loopback: False # Keep loopback interface outside of SRv6 SID |
Collaborator
There was a problem hiding this comment.
We may want to remove this knob altogether, I initially thought this was a good idea but it does not solve the chicken-and-egg routing problem and mainly causes confusion
jbemmel
reviewed
May 10, 2026
| {% if srv6.vpn is defined %} | ||
| {% for n in bgp.neighbors|default([]) if n.ipv6 is defined %} | ||
| {% if srv6.vpn|default(False) or srv6.bgp|default(False) %} | ||
| {% for n in bgp.neighbors|default([]) if n.ipv6 is defined and n.type == 'ibgp' %} |
Collaborator
There was a problem hiding this comment.
If this is limited to IBGP neighbors, we should probably document that more explicitly
jbemmel
approved these changes
May 10, 2026
Collaborator
jbemmel
left a comment
jbemmel
left a comment
There was a problem hiding this comment.
Documentation suggestion, deprecating srv6.allocate_loopback could also be a separate PR
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work done by @jbemmel in #3263
Also includes: cleaned-up integration tests