Skip to content

WIP: Skills question endpoint#798

Open
barna-isaac wants to merge 8 commits into
mainfrom
feature/skills-questions-endpoint
Open

WIP: Skills question endpoint#798
barna-isaac wants to merge 8 commits into
mainfrom
feature/skills-questions-endpoint

Conversation

@barna-isaac

Copy link
Copy Markdown
Contributor

Pull Request Check List

  • Unit Tests & Regression Tests Added (Optional)
  • Removed Unnecessary Logs/System.Outs/Comments/TODOs
  • Added enough Logging to monitor expected behaviour change
  • Security - Injection - everything run by an interpreter (SQL, OS...) is either validated or escaped
  • Security - Data Exposure - PII is not stored or sent unencrypted
  • Security - Data Exposure - Test any altered or created endpoints using swagger
  • Security - Access Control - Check authorisation on every new endpoint
  • Security - New dependency - configured sensibly not relying on defaults
  • Security - New dependency - Searched for any know vulnerabilities
  • Security - New dependency - Signed up team to mailing list
  • Security - New dependency - Added to dependency list
  • DB schema changes - postgres-rutherford-create-script updated
  • DB schema changes - upgrade script created matching create script
  • Updated Release Procedure & Documentation (& Considered Implications to Previous Versions)
  • Peer-Reviewed

userManager.getCurrentRegisteredUser(request);
if (!(this.contentManager.getContentDOById(appId) instanceof AnvilApp)) {
var error = new SegueErrorResponse(Status.NOT_FOUND, "No app found for given id: " + appId);
log.warn(error.getErrorMessage());
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.38%. Comparing base (45bb1b3) to head (b0b2d76).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../cam/cl/dtg/isaac/dto/AnvilMarkingResponseDTO.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   40.25%   40.38%   +0.13%     
==========================================
  Files         547      551       +4     
  Lines       23810    23848      +38     
  Branches     2901     2902       +1     
==========================================
+ Hits         9584     9631      +47     
+ Misses      13323    13314       -9     
  Partials      903      903              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants